search

ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
34 stars 89 forks source link

chore: temporarily disable storage changes workflow for pull requests #878

Closed gitcoindev closed 8 months ago

gitcoindev commented 8 months ago

Temporarily disable for pull requests until limiting rate API issue is resolved.

Reference: #876

gitcoindev commented 8 months ago

but let's get to the root of the cause @gitcoindev, as this is one of the most sophisticated implementation we have that checks for diamond storage

CodeQL triggered the rate limit API error, perhaps it is the root cause or combination of both: CodeQL analysis and storage changes. I disabled this one as well.

gitcoindev commented 8 months ago

Now coverage job is failing, coveralls server is down or API endpoint not responding. I triggered it 3 times already with the same result..

📄 Using coverage file: packages/contracts/filtered-lcov.info 🚀 Posting coverage data to https://coveralls.io/api/v1/jobs ⚠️ Internal server error. Please contact Coveralls team. Error: Process completed with exit code 1.

0x4007 commented 8 months ago

Isn't there a coverage solution we can use that doesn't require third party APIs? I'm out at an event now or else I would contribute more useful research.

https://www.perplexity.ai/search/486e5ef2-96ef-4ac8-8845-818f8bfd0f3b

gitcoindev commented 8 months ago

Isn't there a coverage solution we can use that doesn't require third party APIs? I'm out at an event now or else I would contribute more useful research.

https://www.perplexity.ai/search/486e5ef2-96ef-4ac8-8845-818f8bfd0f3b

Coveralls is fixed now, this was a temporary glitch on their side. But if this happens again we could consider other options.