search

ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
34 stars 91 forks source link

Fix set role admin #879

Closed gitcoindev closed 10 months ago

gitcoindev commented 10 months ago

Resolves https://github.com/sherlock-audit/2023-12-ubiquity-judging/issues/90

molecula451 commented 10 months ago

closing reopening? 😆

gitcoindev commented 10 months ago

@molecula451 I am sorry for the spam. I was confused and realized too late that we disabled GraphQL and contract storage changes workflows in development branch, but fix-review branch still has it enabled. So it is enabled and still failing here..

molecula451 commented 10 months ago

yeah you pointed the disabled to the development branch lol

molecula451 commented 10 months ago

doesn't look clean, the PR is gathering my commits to this PR, better just re-do the disable

gitcoindev commented 10 months ago

doesn't look clean, the PR is gathering my commits to this PR, better just re-do the disable

You are right. Let me clean up this now. I will delete the pr, merge development to fix-review. Then base my pull request on the updated fix-review.