search

ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
34 stars 91 forks source link

[LOW] - Collateral ratio should be capped #929

Closed 0xadrii closed 7 months ago

0xadrii commented 7 months ago 
          [LOW] - Collateral ratio should be capped

As seen in Frax's code, collateral ratio will always be capped at 100%. For Ubiquity, if a higher value is wrongly set and the dynamic CR is implemented, then it could cause some issues. It is recommended to add a maximum value for newCollateralRatio of 1_000_000.

_Originally posted by @0xadrii in https://github.com/ubiquity/ubiquity-dollar/pull/922#discussion_r1572505552_

gitcoindev commented 7 months ago

Seems straightforward to implement, I will pick it up.

ubiquibot[bot] commented 7 months ago 
! action has an uncaught error