ubiquity / work.ubq.fi

A user interface for https://github.com/ubiquity/devpool-directory/issues
https://work.ubq.fi
2 stars 26 forks source link

The user name is not displayed for user who didn't set a name #61

Closed gentlementlegen closed 4 months ago

gentlementlegen commented 5 months ago

name is not required for a GitHub user, it can be left blank, which results in the UI missing the name of the user.

image

Maybe it would be better to use the login field which is required and cannot be left blank for GitHub users.

See also: https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28#get-a-user

0x4007 commented 5 months ago

Should fallback to login if name is not found. That seems more proper.

ubiquibot[bot] commented 4 months ago
+ Evaluating results. Please wait...
ubiquibot[bot] commented 4 months ago

[ 2.3 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment12.3
Conversation Incentives
CommentFormattingRelevanceReward
Should fallback to `login` if name is not found. That se...
2.3
code:
  count: 1
  score: "1"
  words: 1
12.3

[ 39.4 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification114.4
IssueTask125
Conversation Incentives
CommentFormattingRelevanceReward
`name` is not required for a GitHub user, it can be left...
14.4
code:
  count: 2
  score: "2"
  words: 2
114.4
ubiquity-os-main[bot] commented 4 months ago

[ 1.386 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 1.386
Conversation Incentives
Comment Formatting Relevance Reward
Should fallback to `login` if name is not found. That se…
1.4
content:
  p:
    count: 13
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.99 1.386

[ 30 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Issue Specification 1 5
Conversation Incentives
Comment Formatting Relevance Reward
`name` is not required for a GitHub user, it can be left…
5
content:
  p:
    count: 48
    score: 1
  code:
    count: 2
    score: 1
  img:
    count: 1
    score: 0
wordValue: 0.1
formattingMultiplier: 1
1 5