ubirak / rest-api-behat-extension

Stuff to easily test your rest api with Behat
MIT License
38 stars 24 forks source link

Update dependencies for php8 compatibility #103

Closed adalessa closed 3 years ago

adalessa commented 3 years ago

Updating a project to use PHP 8, failed due the dependencies php-http/client-common and php-http/guzzle6-adapter hold back to PHP 7. Updating them allow it to be use with php 8, and local test still running.

armandabric commented 3 years ago

The proposed package seems not compatible with PHP 7. @tyx wdyt?

tyx commented 3 years ago

a new major version can be envisaged to support php8 !

tyx commented 3 years ago

We need to update the .travis.yml by adding php8 to the matrice to ensure this PR is ok.

adalessa commented 3 years ago

Thanks for the replies. I have been testing and I have updated travis with what I believe is a valid configuration, and I have updated the requirements to be compatible in all the expected forms for versions of PHP 7.2, 7.3, 7.4 and of course 8.0

tyx commented 3 years ago

It looks great ! Thanks a lot @adalessa !