ubis / Freya

Freya - Cabal Online MMORPG OpenSource Server Emulator
MIT License
46 stars 18 forks source link

Feature/inventory move #4

Closed artem-alekseev closed 1 year ago

artem-alekseev commented 1 year ago

I'm just learning GO, please point out my errors, I would like to help you in the project

I will improve it a little later, it is still not perfect and does not send notification packets

ubis commented 1 year ago

I'm just learning GO, please point out my errors, I would like to help you in the project

Hey, thanks for PR! Sure, let me take a look into these changes.

artem-alekseev commented 1 year ago

I added sending notification packages, now you can see equipping and unequipping on characters I think that this will require improvements, such as pet equipment and others.

I would like something else to help the project, can you tell me what to do next

ubis commented 1 year ago

I guess we should merge this PR first, and to do that, you should look into my comments. And later, perhaps you could look into skills (casting) or quests or NPC's. There is also a problem with astral-gun characters such as ForceShielder/ForceArcher - these are stuck when entered the world, most likely because client tries to cast astral weapon skill.

Now I'm working on a world manager and a proper world cell management and then we will have monsters in a world map.

artem-alekseev commented 1 year ago

I also noticed that the equipment and inventory are not updated when you exit before changing the character, it only works if you exit before choosing a server

ubis commented 1 year ago

This is weird, since DB is actually updated, I would need to check it.

artem-alekseev commented 1 year ago

And I also didn't see any comments on the code, have you already checked it or is it in progress?

I'll try to figure out the activation of astral-gun skills

ubis commented 1 year ago

And I also didn't see any comments on the code, have you already checked it or is it in progress?

I'll try to figure out the activation of astral-gun skills

Ah yes, sorry. I forgot to end the review :D

artem-alekseev commented 1 year ago

Could you give me access to the repository so I can push to your branches, it's very inconvenient to work through fork

ubis commented 1 year ago

artem-alekseev

Sure, I've sent the invite.