search

ubisoft / Sharpmake

Sharpmake is an open-source C#-based solution for generating project definition files, such as Visual Studio projects and solutions, GNU makefiles, Xcode projects, etc.
Apache License 2.0
927 stars 171 forks source link

Fix for a bug that is causing duplicated CLRSupport entries in C++/CL… #283

Closed melrob closed 8 months ago

melrob commented 1 year ago

This is a fix for an issue that is causing the generation of unusable project files for c++/CLR when the NET version is set to 6.0.

The element CLRSupport was being generated twice in the property group.

This has been undetected for a long time, because the duplicated entry with identical values doesn't have any influence when the project is parsed.

However, when the project is configured to generate net6.0, we are getting one entry with "NetCore" and another entry with "true". The second entry overrides the first.

As result of this, the project fails to correctly handle netcore.

bchampoux commented 9 months ago

hi @melrob we've released 0.40.0 which has a fix for the duplicate ClrSupport entry and support for /clr:netcore, can you try it and see if that makes your contribution here pointless? (sorry!)

jspelletier commented 8 months ago

I think this is not needed anymore. If something is still needed, open a new one.