search

ubisoft / Sharpmake

Sharpmake is an open-source C#-based solution for generating project definition files, such as Visual Studio projects and solutions, GNU makefiles, Xcode projects, etc.
Apache License 2.0
922 stars 168 forks source link

Fix configuration of MSBuild unity/jumbo build parameters #314

Closed Trithek closed 8 months ago

Trithek commented 8 months ago

Move jumbo build configuration parameters to ClCompile block

While enabling the unity build needs to be in the PropertyGroup, the configuration parameters need to be in ClCompile in order to be picked up correctly.

jspelletier commented 8 months ago

@Say-Y Can you validate this change on your side? We don't use jumbo build at Ubisoft so it is hard for us to test/validate this.

Say-Y commented 8 months ago

JumboBuild Hi @jspelletier, @Trithek edit is correct. My mistake. If you check in VS, you can see that it is added to ClCompile.

jspelletier commented 8 months ago

thanks

jspelletier commented 8 months ago

JumboBuild Hi @jspelletier, @Trithek edit is correct. My mistake. If you check in VS, you can see that it is added to ClCompile.

thanks. the change is merged.