search

ubisoft / Sharpmake

Sharpmake is an open-source C#-based solution for generating project definition files, such as Visual Studio projects and solutions, GNU makefiles, Xcode projects, etc.
Apache License 2.0
922 stars 168 forks source link

Move to .NET 8 #318

Closed cmello closed 7 months ago

cmello commented 8 months ago

Hi,

If you would be interested in moving to .NET 8, this PR might be helpful.

Thanks!

Best regards, Cesar

baudronp commented 8 months ago

Thanks @cmello for the PR!

We are also planning to move to net8, but there is deployment consideration that we need to tackle first 🙂

We may also considere multitargetting to net6 and net8 to let other external devs plan there migration at there own pace.

Anyway we will take a look a your PR, and maybe not take it exactly as is/redo it (don't take it personnally if we do 😅).

cmello commented 8 months ago

Thank you for the kind words @baudronp . :-) No rush, I was just taking a look at the amount of work it would take to upgrade to .NET 8, and shared the experiment as it could be helpful when migrating to .NET 8 for real. Thanks!

jspelletier commented 8 months ago

Hello Cesar, You are interested into targetting .net 8 in the generated csproj or running sharpmake under .net 8? These are two totally different things. I see you did both. Targetting .net 8 in the generated csproj is a trivial change that could and should be submitted separately from an update of sharpmake for .net 8.

cmello commented 8 months ago

Hi Jean, I am interested in both. But neither is urgent. I can submit the csproj generation one separately if it looks correct. Thanks for your attention!

jspelletier commented 8 months ago

please create a PR for the csproj .net8 generation.

cmello commented 8 months ago

PR for csproj .NET 8 generation: #319

Thanks!

cmello commented 7 months ago

Unintentionally removed the PR contents while cleaning up my fork branches. The code corresponding to this PR is available in branch https://github.com/cmello/Sharpmake/tree/upgrade_to_net8 , but I am not moving forward with it for now. Thanks!