Update most of VS2017 samples to VS2022 and make sure samples are run on the proper runner on GitHub

ubisoft / Sharpmake

Sharpmake is an open-source C#-based solution for generating project definition files, such as Visual Studio projects and solutions, GNU makefiles, Xcode projects, etc.

Apache License 2.0

922 stars 168 forks source link

Update most of VS2017 samples to VS2022 and make sure samples are run on the proper runner on GitHub #372

Closed sylvainfortin closed 3 months ago

sylvainfortin commented 3 months ago

A Vs2022 sample must run on a windows-2022 runner. Same for Vs2019. GitHub runner image no longer support multiple VS build tools. See related announcement: https://github.com/actions/runner-images/issues/9701.

I believe there is more cleanup to do in SamplesDef.json to make sure solutions generated by samples are ran on corresponding runner image and VS versions. But this is a first pass that focus on fixing GitHub build.

bchampoux commented 3 months ago

Looks fine to me. There are indeed more samples to change to normalize everything but I'm okay with fixing GitHub first. Maybe we should also get rid of .NET 4.7.2 and move on to a recent version.