search

ubisoft / mixer

Add-on for real-time collaboration in Blender.
https://ubisoft-mixer.readthedocs.io/
GNU General Public License v3.0
1.32k stars 77 forks source link

Avoid crash on paint_active_slot in Blender 2.93 #27

Closed fire closed 2 years ago

fire commented 2 years ago

Fixes: https://github.com/ubisoft/mixer/issues/20 Fixes: https://github.com/ubisoft/mixer/issues/18 Fixes: https://github.com/ubisoft/mixer/issues/26

Can someone test?

I don't like the location of key check. Any better designs?

fire commented 2 years ago

Can you review? @werwack

charlesfleche commented 2 years ago

This fix works: tested on Ubuntu 21.04 with blender 2.93.5

fire commented 2 years ago

@Celeborn2BeAlive Who can review this and how can I have issues reviewed in a timely manner?

rennmaus-coder commented 2 years ago

@fire you should try if this pull request works for you

fire commented 2 years ago

@rennmaus-coder does it not work? I tested when I created the pr.

Edited:

I retested on Blender 2.93.5 and aside from the version symbol, mixer works for me for two clients on the same computer rather than the previous state which was crashing.

rennmaus-coder commented 2 years ago

@fire OK, I thought you were the one who created the issue, sorry. And no, unfortunately it doesn't work for me. Tomorrow I will edit this post with further information...

fire commented 2 years ago

@rennmaus-coder Were you able to get it to work?

rennmaus-coder commented 2 years ago

Yeah, I think I just didn't install the Plugin properly, sorry.