search

ubisoft / mixer

Add-on for real-time collaboration in Blender.
https://ubisoft-mixer.readthedocs.io/
GNU General Public License v3.0
1.32k stars 79 forks source link

Sync in Edit Mode #8

Closed SteveSmithSoftware closed 4 years ago

SteveSmithSoftware commented 4 years ago

Hi Guys, I have made a few small changes to your code to allow changes in Edit Mode to be seen in real time by other room users. Shall I make a pull request for this or is it something you have already covered?

fire commented 4 years ago

I'm not a core contributor to this project, but I'd like to see it!

Celeborn2BeAlive commented 4 years ago

Hi @SteveSmithSoftware , thanks for experimenting with Mixer ! You can submit a pull request and we'll try to merge it as soon as possible. Did you tried on big meshes ? It is not too expensive ?

SteveSmithSoftware commented 4 years ago

I'm not a core contributor to this project, but I'd like to see it!

It's still very rough around the edges but mixer.zip

it is only small changes to the attached 3 .py files. I have commented where I have changed

SteveSmithSoftware commented 4 years ago

Hi @SteveSmithSoftware , thanks for experimenting with Mixer ! You can submit a pull request and we'll try to merge it as soon as possible. Did you tried on big meshes ? It is not too expensive ?

No I haven't tried it with large meshes. I will make it 'nice' i.e. add option to turn on and off and I will look at the socket code to see if it can be a little more efficient

Celeborn2BeAlive commented 4 years ago

Great, indeed an option could be required for large scenes.

Fill free to open (and update) a pull request to share your code, it will be more practical than an zip file, and also more easy for you to merge our master branch regularly. However if you can it would be better to fork and open the merge request on our gitlab mirror https://gitlab.com/ubisoft-animation-studio/mixer since we do our daily devs in a gitlab instance (we can also run tests, lint, etc on it thanks to our Gitlab CI script). Not strictly required though, if you prefer Github that's ok.

Celeborn2BeAlive commented 4 years ago

Closing this issue because we are moving discussions to https://gitlab.com/ubisoft-animation-studio/mixer.

@SteveSmithSoftware If you want to continue this discussion, please open a new issue on Gitlab, thanks ! Also you can open a merge request on it if you want us to review your changes and integrate them (be sure to make it optional though since edit mode sync can be expensive)