Update current test cases

[kxepal]

subj.

[ghost]

@kxepal Need some details here of the work -- do you mean the spec itself should provide more example/sample files or a certain impl on a certain platform needs more test cases?

[kxepal]

@thebuzzmedia more examples with valid and malformed UBJSON data. For example:

[S][i][-3][foo]
[{][i][42][S][i][3][bar][}]
[[][i][1][[][i][2][]]
[S][i][N][3][baz]
[d]\x00\x00\x80\x7f  #   infinity value is not allowed

and etc. to help developers synchronise libraries behaviour, clearly define invalid cases and suggest common ways to react on them and so on. Current ones are good and even suitable for benchmarking, but they covers only positive scenarios while there are a lot of negative ones.

[ghost]

Absolutely agree, thank you for clarifying.

---

Riyad http://thebuzzmedia.com

On Sun, Apr 14, 2013 at 11:29 AM, Alexander Shorin <notifications@github.com

wrote:

@thebuzzmedia https://github.com/thebuzzmedia more examples with valid and malformed UBJSON data. For example:

[S][i][-3][foo] [{][i][42][S][i][3][bar][}] [[][i][1][[][i][2][]] [S][i][N][3][baz] [d]\x00\x00\x80\x7f # infinity value is not allowed

and etc. to help developers synchronise libraries behaviour, clearly define invalid cases and suggest common ways to react on them and so on. Current oneshttps://github.com/thebuzzmedia/universal-binary-json-java/tree/master/src/test/resources/org/ubjsonare good and even suitable for benchmarking, but they covers only positive scenarios while there are a lot of negative ones.

— Reply to this email directly or view it on GitHubhttps://github.com/thebuzzmedia/universal-binary-json/issues/8#issuecomment-16356588 .

[DbxDev]

Reviving this old issue. The test cases provided are clearly not following the current specifications. I would be good to move those files to a directory specifying the draft version they follow. For example TwitterTimeline.ubj starts with byte 111 which is [o](for object I guess), but current draft uses [{].

[rkalla]

You are right those examples are all Draft 8. I handed ownership to Steven Braeger recently and I think he has some plans on cleaning a lot of this up.

On Thu, Oct 13, 2016 at 12:26 PM, Dorian notifications@github.com wrote:

Reviving this old issue. The test cases provided are clearly not following the current specifications. I would be good to move those files to a directory specifying the draft version they follow. For example TwitterTimeline.ubj starts with byte 111 which is o http://for%20object%20I%20guess, but current draft uses [{].

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ubjson/universal-binary-json/issues/8#issuecomment-253613398, or mute the thread https://github.com/notifications/unsubscribe-auth/AARteDoU-6RaleNsNNnjR2dA1fDVP8D1ks5qzoXjgaJpZM4AGwXs .