search

ublox-rs / ublox

Rust crate to talk UBX protocol to u-blox GPS devices.
MIT License
54 stars 30 forks source link

use uniform `itow` naming across packets #64

Closed andrei-ng closed 1 year ago

andrei-ng commented 1 year ago

@gwbres would you have time to approve this ?

gwbres commented 1 year ago

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

andrei-ng commented 1 year ago

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

IMO it should stay "itow" as in the manual since the meaning apparently (I had to search for it myself) is "Integer Time Of Week" which is meant to differentiate it from "TOW" that has typical units seconds.

What is your point of view?

gwbres commented 1 year ago

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

IMO it should stay "itow" as in the manual since the meaning apparently (I had to search for it myself) is "Integer Time Of Week" which is meant to differentiate it from "TOW" that has typical units seconds.

What is your point of view?

Oh I did'nt know it was the official name in the UBX definitions. Let's keep it that way then

andrei-ng commented 1 year ago

@gwbres would you have time to approve this ?

Hello, yes I do. what do you think about renaming to tow ?

IMO it should stay "itow" as in the manual since the meaning apparently (I had to search for it myself) is "Integer Time Of Week" which is meant to differentiate it from "TOW" that has typical units seconds. What is your point of view?

Oh I did'nt know it was the official name in the UBX definitions. Let's keep it that way then

I didn't know why it was named iTow specifically either before you asked. So good you asked, we both learned something today :) .

For completeness, from the uBLOX F9P manual :

The original designers of GPS chose to express time/date as an integer week number (starting with the first full week in January 1980) and a time of week (often abbreviated to TOW) expressed in seconds. Manipulating time/date in this form is far easier for digital systems than the more conventional year/month/day, hour/minute/second representation. Consequently, most GNSS receivers use this representation internally, only converting to a more conventional form at external interfaces. The iTOW field is the most obvious externally visible consequence of this internal representation.

https://content.u-blox.com/sites/default/files/ZED-F9P_IntegrationManual_UBX-18010802.pdf