search

ublue-os / akmods

A caching layer for pre-built Fedora akmod RPMs
Apache License 2.0
40 stars 31 forks source link

feat: Use the same containerfile for both Nvidia builds #225

Open dylanmtaylor opened 1 month ago

dylanmtaylor commented 1 month ago

This PR attempts to build both containers using the same file. Not yet tested, just submitting for some early feedback.

dylanmtaylor commented 1 month ago

This might be good to go in. The legacy driver build is showing NVIDIA_FLAVOR=nvidia, and the open build is showing nvidia-open. image image

dylanmtaylor commented 1 month ago

I removed the labels and it worked. I think something in the github action to parse labels to command line args is breaking it ❯ buildah bud -f Containerfile.nvidia --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40 ... [2/3] STEP 16/18: ARG NVIDIA_FLAVOR [2/3] STEP 17/18: RUN DRIVER_TYPE=$([ "${NVIDIA_FLAVOR}" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE nf nvidia-legacy - dt kernel