ublue-os / bazzite

Bazzite is a custom image built upon Fedora Atomic Desktops that brings the best of Linux gaming to all of your devices - including your favorite handheld.
https://bazzite.gg
Apache License 2.0
3.73k stars 219 forks source link

[Original Ally] - Broken Rainbow RGB (Fix in issue) #1153

Closed Bladen123 closed 3 weeks ago

Bladen123 commented 4 months ago

Bazzite Dev Note:

Fix can be found here: https://github.com/ublue-os/bazzite/issues/1153#issuecomment-2322934767

-----------------------------------------------------------------------------------

Describe the bug

I installed BazziteOS used that for some hours to test my games , after that i reinstalled windows 11 and armory crate every thing seems to work normal beside the RGB Rainbow , the RGB works as solid color or whatever i want also the aura sync works and the modes too. Only that doesnt work is the standard Rainbow RGB if i choos that the rgb is off like no light.

What did you expect to happen?

Normaly isnt first time i used bazziteOS , last time was kind similar but instad rgb are like OFF was red light only until i reinstalled windows and armory crate after that my rgb worked normal as should even the rainbow color. so i expected to work after fresh windows install , but this time it doesnt i feel like something happend with the latest bazzite OS updates.

Output of rpm-ostree status

No response

Hardware

ROG ALLY Z1 Extreme

Extra information or context

No response

antonyho commented 4 months ago

Having the same situation. And there are occurrences that the right stick has RGB light on, and the left stick has light off when a mode has something wrong. There are some new modes on the Armoury Crate now. They all don't work.

image

mrwhistles commented 4 months ago

This happened to me as well. At this point the "rainbow" option didn't work at all except through aura sync. This is what I did:

In windows/Armory Crate I turned off all LEDs for all situations. I rebooted into bazzite and rolled back to a previous release (bazzite-rollback-helper rebase 40-20240427) Booted windows, turned LEDs back on and now everything is back to normal and I can enable the "rainbow" visual.

Not 100% sure which parts of that are essential but that did get me back to normal working RGB visuals.

antheas commented 3 months ago

Im adding Rainbow support to hhd and noticed it was broken, care to expand?

antheas commented 3 months ago

image

so you say 7 is the image that works and this commit was made on the 8th ey?

KyleGospo commented 2 months ago

Closed for no response

antheas commented 2 months ago

It's a major bug, reopen

KyleGospo commented 2 months ago

It's a major bug, reopen

Commenting here due to most discussion being in discord. I believe the current status is we've fixed this and are looking for a way to restore existing broken RGB, is that correct?

antheas commented 2 months ago

Yes, only Allys that used an image in May are affected. We have found and fixed the bug that we suspected and most of our current testers have working rainbow RGB in Bazzite (called spiral in Handheld Daemon).

Next Handheld Daemon version adds a more indepth initialization which may help with fixing the affected devices as well, but we have not verified this yet.

We are looking for additional testers though so reach out, especially if you are affected.

antheas commented 2 months ago

I also maintain an image here which is based on the 0427 image that is known to fix the issue and is not close to expiring https://github.com/hhd-dev/bazzite-dc

Harithz001 commented 2 months ago

I also maintain an image here which is based on the 0427 image that is known to fix the issue and is not close to expiring https://github.com/hhd-dev/bazzite-dc

Tried rebasing to this image, the spiral rgb worked in bazzite but windows rainbow led still is broke. I then tried disabling led support on hhd and reinstall windows through cloud recovery but this does not fix the rainbow led in windows.

Evilexium commented 2 months ago

I also maintain an image here which is based on the 0427 image that is known to fix the issue and is not close to expiring https://github.com/hhd-dev/bazzite-dc

I tryed this too , Now suddenly NO LIGHTS at all not even the RGB settings in HHD theyr gone at all , and worst of all my controller suddenly doesnt work outside of bazzite , for example in BIOS my controller doesnt work after this update, IT makes me crazy that its get worser and worser one day i can throw this ally to trash

Kylorenzzz commented 2 months ago

I also maintain an image here which is based on the 0427 image that is known to fix the issue and is not close to expiring https://github.com/hhd-dev/bazzite-dc

Tried this and does not work. Bazzite broke my rainbow rgb too. And it's such bad timing as I am receiving my Ally X in a few days yet I am stuck as I could not re-sell my device due to the broken rgb lights. Pls help!!!

Evilexium commented 2 months ago

Yes, only Allys that used an image in May are affected. We have found and fixed the bug that we suspected and most of our current testers have working rainbow RGB in Bazzite (called spiral in Handheld Daemon).

Next Handheld Daemon version adds a more indepth initialization which may help with fixing the affected devices as well, but we have not verified this yet.

We are looking for additional testers though so reach out, especially if you are affected.

Before this New BazziteOS came out that broke even more of the rogs , we just did rebase to i think 39-20240406 and that fixed the rgb , now even that doesnt fix it and my controller isnt recognized by bios anymore since i rebased to this https://github.com/hhd-dev/bazzite-dc

antheas commented 2 months ago

Yes, there is a missing initialization command in the current version.

If you guys can run the following command:

curl https://raw.githubusercontent.com/hhd-dev/hhd/master/local_hhd.sh | sh

If the old image fixed this this will as well.

antheas commented 2 months ago

In any case, I am working with an ally right now and I should have a solution to this today.

antheas commented 2 months ago

I pushed a version that fixes the RGB initialization bug that got introduced in the Ally X version.

https://github.com/hhd-dev/hhd/releases/tag/v3.2.2

antheas commented 2 months ago

bazzite-dc is updated with the new Handheld Daemon version that does the proper init. Hopefully it helps.

We also tried booting into one of the bazzite images that had the issue and the rainbow mode worked there and then worked in windows as well.

Evilexium commented 2 months ago

Will give a Try and will post soon here back. Thank you Antheas for all this extreme efforts u invest into this also i have a question , on my 4TB i use cachyOS everything works there , never had problems with that linux to destroy rgb on windows . only that doesnt work is the new spiral does this command fix that on any linux ?

this one just to know curiosity :)

curl https://raw.githubusercontent.com/hhd-dev/hhd/master/local_hhd.sh | sh

antheas commented 2 months ago

That command installs the new version until you reboot, which you're going to get eventually on CachyOS.

I do not think CachyOS was affected by the bug (yet)

Yqw175 commented 2 months ago

curl https://raw.githubusercontent.com/hhd-dev/hhd/master/local_hhd.sh | sh rpm-ostree rebase ostree-unverified-registry:ghcr.io/hhd-dev/bazzite-dc:stable

The above two tests did not fix the rainbow

antheas commented 2 months ago

We have had at least 4 people with working spiral mode still show that it is working in the current version. Including one verifying it in windows.

Therefore, the issue does not happen in current images and the question becomes how reset current devices.

Searching online there does not seem to be a way to reset the MCU, so we need to look into how to do that.

The legion go, for example, has at least 2 ways to reset its controllers.

antheas commented 2 months ago

Is it fair to assume all of you guys are both on the latest bios (339) and controller firmware (V317)?

SuperSirLink commented 2 months ago

if it helps, I have encountered a similar issue with the RGB/Spiral setting, I did not have Bazzite installed, but did have Nobara 40 and I was trying to follow the instructions to install Nvidia drivers and asusctl and supergfxctl per the Asus-linux.org page. Noticed the went dark at some point, reboot to Windows (on an external drive) and found I still didn't have the rainbow setting come on. all the other modes work fine.

I am also on the latest bios and current firmware

KyleGospo commented 2 months ago

if it helps, I have encountered a similar issue with the RGB/Spiral setting, I did not have Bazzite installed, but did have Nobara 40 and I was trying to follow the instructions to install Nvidia drivers and asusctl and supergfxctl per the Asus-linux.org page. Noticed the went dark at some point, reboot to Windows (on an external drive) and found I still didn't have the rainbow setting come on. all the other modes work fine.

I am also on the latest bios and current firmware

That tracks, we've suspected this is software that we don't write causing this.

Very much appreciate the info, hopefully we find a solution to fix devices already affected by this soon.

SuperSirLink commented 2 months ago

I will also note that I am running the latest version of HHD when installing from: curl -L https://github.com/hhd-dev/hhd/raw/master/install.sh | bash

Evilexium commented 2 months ago

Is it fair to assume all of you guys are both on the latest bios (339) and controller firmware (V317)?

Yes i am , still didnt worked all the attempts i got here to try

Evilexium commented 2 months ago

if it helps, I have encountered a similar issue with the RGB/Spiral setting, I did not have Bazzite installed, but did have Nobara 40 and I was trying to follow the instructions to install Nvidia drivers and asusctl and supergfxctl per the Asus-linux.org page. Noticed the went dark at some point, reboot to Windows (on an external drive) and found I still didn't have the rainbow setting come on. all the other modes work fine.

I am also on the latest bios and current firmware

That was allways like this , on windows allways worked all even aura , was months ago same , what we want is the rainbow on windows back

SuperSirLink commented 2 months ago

if it helps, I have encountered a similar issue with the RGB/Spiral setting, I did not have Bazzite installed, but did have Nobara 40 and I was trying to follow the instructions to install Nvidia drivers and asusctl and supergfxctl per the Asus-linux.org page. Noticed the went dark at some point, reboot to Windows (on an external drive) and found I still didn't have the rainbow setting come on. all the other modes work fine. I am also on the latest bios and current firmware

That was allways like this , on windows allways worked all even aura , was months ago same , what we want is the rainbow on windows back

No what I am saying is if I reboot into windows, I RGB works on any mode including Aura, except Rainbow. The leds remain off.

SuperSirLink commented 2 months ago

I installed Bazzite and can confirm that did not fix the issue.

antheas commented 2 months ago

In-between my previous message, we also tried a variety of other fixes that also did not work. The local_hhd uses the latest Handheld Daemon version until reboot, where I tried to include additional LED fixes that seem to not help. Bazzite will include the latest version later today, so you can stop using it now.

We have reached out to Asus for the issue. I will keep the thread up to date as we receive more information.

In any case, I also heard that the Ally had this problem in a worse form in Windows early post launch, where none of the LEDs would work outside Aura mode. So it is a firmware quirk that is easily fixable with a firmware update.

As it is holidays in most of the world and Asus are working professionals, it might take a while for a fix to trickle down to Windows and Linux. So I would advise some patience.

I will re-iterate that the current versions of Bazzite do not cause this issue. This has been tested on both on the original Ally and Ally X. It is also unclear the previous versions did, as we tried to break the rainbow mode on an Ally by using one of those builds and could not.

In addition, I have personally vetted every single command that gets sent to the MCU through Handheld Daemon, which did not change commands since January and June so it could not have caused this, and it has always logged every single MCU LED command it sends.

I have overseen kernel changes in Bazzite that disable the kernel module asus_hid for the Ally and we deprecated the Ally image one month ago, which contained third party code that could be used to control the Ally not vetted by us.

If any of you are on the Ally image, it is recommended to switch to the Deck image using one of the following (depending on your Desktop Environment):

# KDE (bazzite-ally)
rpm-ostree rebase ostree-unverified-registry:ghcr.io/ublue-os/bazzite-deck:stable
# Gnome (bazzite-ally-gnome)
rpm-ostree rebase ostree-unverified-registry:ghcr.io/ublue-os/bazzite-deck-gnome:stable

We kept the old Ally image due to potential user demand for the changes there. However, we might discontinue it sooner because of this.

SuperSirLink commented 2 months ago

If any of you are on the Ally image, it is recommended to switch to the Deck image using one of the following (depending on your Desktop Environment):

# KDE (bazzite-ally)
rpm-ostree rebase ostree-unverified-registry:ghcr.io/ublue-os/bazzite-deck:stable
# Gnome (bazzite-ally-gnome)
rpm-ostree rebase ostree-unverified-registry:ghcr.io/ublue-os/bazzite-deck-gnome:stable

We kept the old Ally image due to potential user demand for the changes there. However, we might discontinue it sooner because of this.

How do we know which image we are on? I just installed it this week, am I good?

us3rnam3d1 commented 1 month ago

Bumping this

installed bazzite somewhere around the end of June, so it’s a June build, no dual boot.

Decided to reinstall windows last week. Rainbow RGB is broken. Before reinstalling, I left the HHD setting to rainbow. Is there any update on the issue?

It’s the same for me, all options except rainbow are working.

Rainbow is also working, but in aura sync mode.

antheas commented 1 month ago

Which image did you install? Deck or Ally? Was it your first/only linux install?

The status is that we have verified that if rainbow works and you are on the deck image, it will not break anymore. We have verified this with both Ally and Ally X. Multiple units.

We still need to do more testing with the Ally image to see if it caused this. We tried over a dozen workarounds to recover the rainbow and cannot yet. Including bios and mcu updates.

Moving forward, we will do some more testing this week trying to make an ally have its RGB Rainbow broken to investigate this issue. Failing that, I am going to do more testing towards the end of this month on an Ally X personally to try to isolate the issue. In addition, we are waiting for a reply from the Asus team, which is getting closer now.

us3rnam3d1 commented 1 month ago

Hi

thanks for the swift reply!

I’m pretty confident it’s the ally image, I downloaded it from the main page and selected ally. It was the only first and only Linux install on the Ally.

I’m running the latest bios and MCU firmware. Not sure if I can provide anything that can be of help to you guys, as my Ally is running windows exclusively now, and I didn’t dual boot in the first place.

If I can do anything from within windows that can help you, let me know

br

Deyan

antheas commented 1 month ago

Hi Deyan, seems like one of the Ally X units will be getting the -ally image treatment sooner than later then

Should be easy to fix after we identify the root cause

Of course, we will make our findings available to Asus and try to provide a windows workaround as well once a solution is found.

I do not think you can help much from Windows though. So we'd appreciate some (more) patience.

Thanks for understanding.

antheas commented 1 month ago

an update for all of you. We have received the following: https://universal-blue.discourse.group/t/rainbow-rgb-not-working-after-reinstalling-windows/3487/3

If any of you are up for testing the fix that would be great. I am currently archiving the image, so do not worry about it expiring.

I will also analyze the package versions in it and 40-20240427 and delve deeper into this to isolate the solution if it does indeed work.

I was always aware of the reddit post, but I never realized they were talking about rebasing to the ally image.

EDIT: The image is too old, so your installation might break. But your RGB might work again!

SuperSirLink commented 1 month ago

I would be happy to test. If we clone to another drive to test, fix the RGB, then go back to the original drive, would that be worth the effort? Or would RGB just break again?

antheas commented 1 month ago

Yes, -deck is fixed. Please don't use the -ally image on the Ally. We will be removing it soon.

As soon as I diff the images and find out what caused it the latest bazzite will also fix the LEDs so you won't need to rebase

Mia-Sophia commented 1 month ago

an update for all of you. We have received the following: https://universal-blue.discourse.group/t/rainbow-rgb-not-working-after-reinstalling-windows/3487/3

If any of you are up for testing the fix that would be great. I am currently archiving the image, so do not worry about it expiring.

I will also analyze the package versions in it and 40-20240427 and delve deeper into this to isolate the solution if it does indeed work.

I was always aware of the reddit post, but I never realized they were talking about rebasing to the ally image.

EDIT: The image is too old, so your installation might break. But your RGB might work again!

i tried this and it did fix my issue

SuperSirLink commented 1 month ago

What are the steps to test? I can also try tonight.

Mia-Sophia commented 1 month ago

What are the steps to test? I can also try tonight. installed Fedora Kinoite 40 iso then rpm-ostree rebase ostree-unverified-registry:ghcr.io/ublue-os/bazzite-ally:39-20240406 and when it came up like the guide said the led was red and i returned to windows and it worked

ElvisChen1986 commented 1 month ago

rpm-ostree rebase ostree-unverified-registry:ghcr.io/ublue-os/bazzite-ally:39-20240406 solved the issue in my rog ally. 40-20240427 does not work

SuperSirLink commented 1 month ago

hmm, unless I did something wrong or my root issue is something else, this didn't work for me

antheas commented 1 month ago

Mind the fact this is a general Linux issue and not particular to Bazzite.

This means that the only image known to not cause it right now is bazzite-deck

How did you check your issue was solved

SuperSirLink commented 1 month ago

I booted back into Windows, opened AC, and switched the leds back to rainbow. But they are still black.

My trigger that broke it was also different. I followed the instructions on ASUS-Linux.org for Fedora workstation. I was trying to install the Nvidia drivers and asusctl / supgfxctl when I lost RGB.

antheas commented 1 month ago

Guess what the Ally image and the steps you followed have in common :)

Do your LEDs not work at all? If yes, I have a command you can run to fix them.

SuperSirLink commented 1 month ago

What? :). Not sure if it matters, but I was running Nobara40 when I ran the commands.

Yeah, all the other modes work in Bazzite and in Windows, only the Spiral/Rainbow is not working in either.

antheas commented 1 month ago

asus-linux stuff

I had a command in case your LEDs did not work at all. We are still trying to figure out what caused the rainbow mode one.

In any case, seems like it is related to the 6 version of asus-linux and asusctl software family. And that running 5.0.10 fixes it. That software seems to be auto-enabling itself when you boot into the ally image. If not, forcing it open might help.

Between 6.0.0 and 5.0.10 there are too many changes for me to be able to pinpoint what caused the issue without a device. With a device, I would be able to sniff the packets. That will happen later this month.

Or sooner, if one of you wants to volunteer.

SuperSirLink commented 1 month ago

ahh, gotcha! So if I am following, might be worth trying to install asusctl 5.0.10? If so, how would I install that version?

Sounds like in theory, if I install that on this temp drive I put 39 back on, the reboot back to Windows/non ally based image of Bazzite, I should be good?

antheas commented 1 month ago

Yes, rebooting straight into windows or bazzite should work. Rebooting somewhere else inbetween no guarantees.

how would I install that version?

Bazzite-ally 39 has this version. If you want to test in another distro you would have to repackage it by finding the package file and then install it...