search

ublue-os / beyond

Cassidy’s playground for GNOME experiments
Apache License 2.0
54 stars 6 forks source link

Extensions: Panel corners #56

Open cassidyjames opened 1 year ago

cassidyjames commented 1 year ago

This is one of those little things and is based on a GNOME design/developer's work.

https://extensions.gnome.org/extension/4805/panel-corners/

Settings:

[org/gnome/shell/extensions/panel-corners]
panel-corners=false
scren-corner-radius=8
screen-corners=true
kdwk commented 1 year ago

I think upstream Gnome removed this because it hurt performance, so it might not be suitable to enable this out-of-the-box

cassidyjames commented 1 year ago

@castrojo ah, am I wrong about this being included by default yet? Does support need to be added elsewhere for this to actually install?

IlChitarrista commented 1 year ago

Reflexion

Hello, I would also like to note a small yet not insignificant issue with this extension. For coherency between the top and bottom edges panel-corners are actually required and with a radius which matches GTK4's rounded corners which, I think, should be around 12 (Not totally sure about this one) not 8.

Proposed Settings

Screenshot from 2023-06-15 12-13-37 image

"Ideal" Settings

image image

Possible Issues

Although this looks great in my opinion I think that it has been removed for performance related issues of which I don't really know the benchmarks. It should be tested but before the implementation moved to an extension using Javascript instead of C.

Also this extension doesn't fade the panel corners on the top in the Activities Overview causing this monstrosity:

image

Conclusion

This could be very interesting but there needs to be a clear performance testing and this issue should be firstly resolved. (Also someone should more accurately assess the correct radius for GTK4 parity)

Edit

I'm trying it out on Wayland on my laptop and the monstrosity I've noticed before is not present, I still have to test Nvidia Wayland out but this could be a Xorg only issue. (Edit 2: Fixed by enabling "Force extension values")

Screencast from 2023-06-15 12-40-00.webm

Although this is better Xorg should be addressed for Nvidia users and the fade out animation is not synced to the top panel such that it is seamless. This is a smaller detail but performance testing should still be addressed first.