ublue-os / bluefin

The next generation Linux workstation, designed for reliability, performance, and sustainability.
https://projectbluefin.io
Apache License 2.0
1.25k stars 163 forks source link

feat: add Samsung ULD drivers from Negativo #1873

Closed tulilirockz closed 2 weeks ago

tulilirockz commented 2 weeks ago

Should fix #1550 and #1604 - Although this seems like it should be added upstream-er, like on ublue-os/main or something.

fiftydinar commented 2 weeks ago

Negativo uld repo is not needed, because negativo multimedia already covers it, as everything else from Negativo (multimedia is an all-in-on repo)

castrojo commented 2 weeks ago

+1 on this, a few users have asked for these.

NiHaiden commented 2 weeks ago

Let's ship this.

bsherman commented 2 weeks ago

I tested a local build where instead of keeping this in the packages.json I later installed it standalone to see if there was some error i was missing in the wall of text:

+ rpm-ostree install uld
Enabled rpm-md repositories: charm tailscale-stable copr:copr.fedorainfracloud.org:ublue-os:staging copr:copr.fedorainfracloud.org:sentry:switcheroo-control_discrete copr:copr.fedorainfracloud.org:che:nerd-fonts copr:copr.fedorainfracloud.org:ublue-os:akmods fedora-multimedia fedora-cisco-openh264 fedora updates updates-archive
Importing rpm-md...done
rpm-md repo 'charm' (cached); generated: 2024-09-12T18:37:10Z solvables: 456
rpm-md repo 'tailscale-stable' (cached); generated: 2024-11-04T22:43:21Z solvables: 112
rpm-md repo 'copr:copr.fedorainfracloud.org:ublue-os:staging' (cached); generated: 2024-11-04T04:02:06Z solvables: 129
rpm-md repo 'copr:copr.fedorainfracloud.org:sentry:switcheroo-control_discrete' (cached); generated: 2024-09-07T08:21:49Z solvables: 5
rpm-md repo 'copr:copr.fedorainfracloud.org:che:nerd-fonts' (cached); generated: 2024-09-17T13:25:30Z solvables: 2
rpm-md repo 'copr:copr.fedorainfracloud.org:ublue-os:akmods' (cached); generated: 2024-10-31T03:51:19Z solvables: 116
rpm-md repo 'fedora-multimedia' (cached); generated: 2024-11-05T12:40:45Z solvables: 380
rpm-md repo 'fedora-cisco-openh264' (cached); generated: 2024-03-11T19:22:31Z solvables: 3
rpm-md repo 'fedora' (cached); generated: 2024-10-25T08:41:19Z solvables: 76624
rpm-md repo 'updates' (cached); generated: 2024-11-06T03:44:47Z solvables: 6296
rpm-md repo 'updates-archive' (cached); generated: 2024-11-06T04:12:58Z solvables: 5163
Resolving dependencies...done
Installing 1 packages:
  uld-1.00.39.12-2.fc41.x86_64 (fedora-multimedia)
Installing: uld-1.00.39.12-2.fc41.x86_64 (fedora-multimedia)
error: Error -1 running transaction
Error: building at STEP "RUN --mount=type=cache,dst=/var/cache/rpm-ostree --mount=type=bind,from=ctx,source=/,target=/ctx /ctx/build_files/shared/build-base.sh": while running runtime: exit status 1

If I had to guess, there's some script running via that RPM's spec file which isn't ostree friendly. But I haven't investigated further.

I will say, I'm glad our PR process is trustworthy enough we can test this before merging.

fiftydinar commented 2 weeks ago

@bsherman Weird thing is that uld installs successfully in my image

bsherman commented 2 weeks ago

Weird thing is that uld installs successfully in my image

Link to the image build? Or do you mean it layers locally? My explanation above allows for local layer install success.

fiftydinar commented 2 weeks ago

@bsherman Ah, I read better now. I meant in my image, not locally.

tulilirockz commented 2 weeks ago

i wonder where are the spec files for that ULD thing. worst case a little bit of patching wont do any harm. right?

castrojo commented 2 weeks ago

I'm +1 to these but taking over maintenance for printer drivers doesn't sound like a good time to me? We could table it for later or see if someone wants to fix them in fedora?

bsherman commented 2 weeks ago

@tulilirockz if you get this working in an image build and want to re-submit, that'll be good. For now, we'll close this.

fiftydinar commented 2 weeks ago

Post setup is just running this:

%?ldconfig
%firewalld_reload

%ldconfig_postun

It seems that using %?ldconfig is not needed anymore: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

But it's probably required for EPEL 8 & 9, which is what's Negativo also targeting.

Maybe that's what's causing the issue.

Doing %firewalld_reload is not needed in build-time, so that can be removed if needed. Maybe even that causes the error, which is harmless. I mean, it works for me in the image-build without errors, so not sure why it's the problem here.