search

ublue-os / bluefin

The next generation Linux workstation, designed for reliability, performance, and sustainability.
https://projectbluefin.io
Apache License 2.0
1.25k stars 163 forks source link

chore: purge all the default container configuration #1901

Open tulilirockz opened 2 weeks ago

tulilirockz commented 2 weeks ago

I believe these are all the references to the Bluefin-CLI container. Probably should not be merged right now? Maybe disabiling the service files then deleting the references seems like the best approach, as Jorge said.

The updated title is just a joke! We talked about this on discord and it seems like it would be best to just get rid of the default containers and stuff

From Jorge:

I'm thinking total purge -
I'd rather spend more time removing as much as we can and then documenting what we have, lean and mean.
the quadlets are in the toolbox repos already

Affects stuff like #1834 and #1881

castrojo commented 2 weeks ago

So I don't mean to hijack this PR. But, looks like the profile setup for ptyxis changed, and now that we have more users people are getting confused.

It might be worth to just rip all of these out and just ship distrobox/boxbuddy blank out of the box:

tulilirockz commented 2 weeks ago

Just converted this into a draft cuz this PR seems kinda big and probably needs a lot more confirmation from everyone

tulilirockz commented 2 weeks ago

I agressively just removed everything related to those default containers, please tell me if you guys dont want something removed!!

Im just wondering about the podmansh.container file in /usr/share/ublue-os/quadlet and /usr/bin/bluefinbox-enter. Should those be removed too?

tulilirockz commented 2 weeks ago

After testing it a bit, this seems fine? Nothing seems to have broken, nothing seems to have changed majorly, my vm seems completely ok and happy

tulilirockz commented 2 weeks ago

Although that ptyxis-create-profile command doesnt seem to be working too well if Ptyxis's dconf keys get reset. It just errors out trying to set transparency since it cant read the default profile uuid off of dconf

castrojo commented 1 week ago

I think we can land this after the conflicts get resolved, and then I'll remove this section from the docs, thanks!

tulilirockz commented 1 week ago

I think we can land this after the conflicts get resolved, and then I'll remove this section from the docs, thanks!

Oh! I didnt even like see the conflicts here LOL i was just editing stuff directly on the my local copy. Sorry! Ill resolve them rn

tulilirockz commented 1 week ago

Hopefully this should be good now

lethedata commented 1 week ago

Are the containers themselves being depreciated or just the bluefin default integration? If it's just the default integration could this be left in the dx version or convert setup to ujust scripts?

I was a bit caught of guard when https://github.com/ublue-os/bluefin/pull/1908 ripped out the bluefin-cli after an updated and it's a but unclear if the container's being depreciated or just the bluefin integration.

m2Giles commented 6 days ago

What's specifically being deprecated is the ephemeral containers that we shipped on ctrl+alt+f and ctrl+alt+u (fedora/ubuntu)

OneCricketeer commented 5 days ago

I've noticed lately that my bluefin-cli is defaulting to Ubuntu now, whereas previously it was Fedora? Also the bluefin-cli terminal no longer has/uses Starship, or Homebrew, where the docs suggest that it should have both...

castrojo commented 5 days ago

Are you trying to use the bluefin-cli container? We deprecated that a long time ago in favor of just using the command on the host.

OneCricketeer commented 5 days ago

Just installed Auroua DX on Framework 13... So, I assume it's the host command, but it's still pulling down the bluefin-os ubuntu container in the Terminal app (which is not Konsole?). And this ubuntu image didn't have brew or ujust. I'm also not sure how it became the default 🤷🏼

The software update app in the launcher seems to run expected shell though.

I feel like I messed something up in the terminal app settings while realizing that I didn't need/want both ubuntu and fedora distroboxes

castrojo commented 5 days ago

Ah yes, if it's a clean install then this issue is how we plan on cleaning it up. 😄

Almost done.

OneCricketeer commented 5 days ago

No rush

https://xkcd.com/1172/

befanyt commented 4 days ago

@tulilirockz I noticed that after your branch updates it seems to be missing the custom2 vs custom3 in the keybindings again. Just to let you know :heart:

tulilirockz commented 4 days ago

@tulilirockz I noticed that after your branch updates it seems to be missing the custom2 vs custom3 in the keybindings again. Just to let you know ❤️

oh great. :p

befanyt commented 4 days ago

@tulilirockz I noticed that after your branch updates it seems to be missing the custom2 vs custom3 in the keybindings again. Just to let you know ❤️

oh great. :p

You applied the commit via my review, that is probably why the commit is missing now. Probably need to commit it again by yourself

m2Giles commented 3 days ago

This is looking good. My only hesitations are cleaning up the old targets and using the name Host for the profile.

Instead I think all of the ptyxis profile manipulation can be ripped out. You should be able to use uuid for the shortcut and it will then just open whatever that profile is configured with.

tulilirockz commented 3 days ago

We also shoukd change the build script orders too since the 06 script got removed - I dont think this should be done in this PR since itll bring merge conflicts unnecessarily AFAIK

tulilirockz commented 3 days ago

This is looking good. My only hesitations are cleaning up the old targets and using the name Host for the profile.

Instead I think all of the ptyxis profile manipulation can be ripped out. You should be able to use uuid for the shortcut and it will then just open whatever that profile is configured with.

Do you think that should be done here? It does bring out the scope a bit - still, great idea! Cleaning up the old targets dont seem like such a huge problem, as this is mostly targeted at new systems that dont have those targets yet, if someone actually notices that those are running, they can remove/disable them on their own I think.