ublue-os / bluefin

The next generation Linux workstation, designed for reliability, performance, and sustainability.
https://projectbluefin.io
Apache License 2.0
1.25k stars 163 forks source link

Switch rollback-helper to bootc switch #1913

Closed castrojo closed 4 days ago

castrojo commented 1 week ago

https://github.com/ublue-os/bluefin/blob/main/system_files/shared/usr/bin/ublue-rollback-helper

This should be using sudo bootc switch ghcr.io/ublue-os/blah --enforce-container-sigpolicy instead.

DarkGhostHunter commented 1 week ago

Does bootc works only when the image has no layered software? Because I wouldn't be able to rebase if the latter is true and I have layered something.

p5 commented 1 week ago

Does bootc works only when the image has no layered software? Because I wouldn't be able to rebase if the latter is true and I have layered something.

If we did this, I'd imagine there would be logic to say "if the image has no layered packages, use Bootc. Otherwise rpm-ostree"

lem4s commented 1 week ago

I tried to implement the change and got an odd result testing it. If the command is run inside the ublue-rollback-helper script, I get the following error message: ERROR Switching: Pulling: Creating importer: failed to invoke method OpenImage: failed to invoke method OpenImage: Requesting bearer token: invalid status code from registry 403 (Forbidden).

However if I just do the same on the console, i.e. run sudo bootc switch ghcr.io/ublue-os/bluefin:41-20241109 myself it starts fetching the image...

Any ideas why this is the case?

m2Giles commented 1 week ago

Likely you have some mangling of the tag or image.

On Sat, Nov 9, 2024, 6:34 PM Malte Schmidt @.***> wrote:

I tried to implement the change and got an odd result testing it. If the command is run inside the ublue-rollback-helper script, I get the following error message: ERROR Switching: Pulling: Creating importer: failed to invoke method OpenImage: failed to invoke method OpenImage: Requesting bearer token: invalid status code from registry 403 (Forbidden) .

However if I just do the same on the console, i.e. run sudo bootc switch ghcr.io/ublue-os/bluefin:41-20241109 myself it starts fetching the image...

Any ideas why this is the case?

— Reply to this email directly, view it on GitHub https://github.com/ublue-os/bluefin/issues/1913#issuecomment-2466502417, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPNFFL74NBQ3F2CVACI6ULZ72LW5AVCNFSM6AAAAABRPKMZRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGUYDENBRG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lem4s commented 1 week ago

Yes you are correct. I found the issue.

castrojo commented 1 week ago

If we did this, I'd imagine there would be logic to say "if the image has no layered packages, use Bootc. Otherwise rpm-ostree"

bootc also tells the user what to do if you try to switch with layers.