ublue-os / bluefin

The next generation Linux workstation, designed for reliability, performance, and sustainability.
https://projectbluefin.io
Apache License 2.0
1.26k stars 162 forks source link

chore(just): clean up ujust recipes to fit newer style #1914

Closed tulilirockz closed 6 days ago

tulilirockz commented 2 weeks ago

Should fix #1805

m2Giles commented 2 weeks ago

We should also use this as an opportunity to clean up stale ones.

m2Giles commented 2 weeks ago

when working with the justfiles. Please be sure to run just fix. We run just check as part of the workflow to make sure we don't ship broken justfiles.

tulilirockz commented 1 week ago

Should I also include a move to bootc on this PR? I am thinking about refactoring most of these scripts to not use rpm-ostree and instead use a wrapper over bootc that allows it to run rootless (ubootc or something)

tulilirockz commented 1 week ago

The indentation on some places also seems a bit funky, ill be reformatting them to always fit 4 spaces indentation

castrojo commented 1 week ago

Should I also include a move to bootc on this PR?

Follow on PRs are always better instead of conflating things.

a wrapper over bootc that allows it to run rootless (ubootc or something)

This is out of scope for us, we're trying to delete as much of our custom stuff as possible these days.

tulilirockz commented 1 week ago

Now the idea was to remove a few old ones, like the pytorch, gnome-vrr, (...) - Anyone has any guesses what to remove? Ill make a little list that i feel that could be deleted

tulilirockz commented 1 week ago

Then we could regroup stuff, honestly I feel like separating it in apps, tools and system doesnt seem like the best? apps and tools could be the same category (tools)

castrojo commented 1 week ago

We need to keep jetbrains (people comment about how useful this is all the time), and the tailscale toggle was an ask in the survey. So let's keep that for people who use other VPNs. Not sure on invokeai so let's keep it for now. We can always do another pass.

castrojo commented 1 week ago

OK one final pass from others would be appreciated on this one! (I know m2 wanted one more look).

tulilirockz commented 1 week ago

Alright, so, after manually testing every single one of the affected recipes, they all seem to work fine, without any major changes. The only ones that I saw that were broken were the toggle-tailscale and setup-ollama ones - just reverted them. The tailscale one also didnt seem to toggle the extension on the Silverblue $VARIANT so I just made it uppercase :p