search

ublue-os / bluefin

The next generation Linux workstation, designed for reliability, performance, and sustainability.
https://projectbluefin.io
Apache License 2.0
1.31k stars 167 forks source link

Just update-firmware on fresh dx latest #722

Closed antonispgs closed 12 months ago

antonispgs commented 12 months ago

Describe the bug

I run just update-firmware on my fresh dx latest system and this is what came up.

just update-firmware 
fwupdmgr refresh --force
Updating lvfs
Downloading…             [***********************                ]
(fwupdmgr:9459): Fwupd-CRITICAL **: 15:19:16.028: fwupd_checksum_guess_kind: assertion 'checksum != NULL' failed
Downloading…             [************************************** ]
Successfully downloaded new metadata: 1 local device supported
fwupdmgr get-updates
Devices with no available firmware updates: 
 • KINGSTON SFYRS1000G
 • KIOXIA-EXCERIA G2 SSD
 • UEFI Device Firmware
 • UEFI Device Firmware
 • WDC WD10EZEX-08WN4A0
Devices with the latest available firmware version:
 • UEFI dbx
No updates available
error: Recipe `update-firmware` failed on line 134 with exit code 2
``` `

### What did you expect to happen?

Not sure this is what's supposed to be returned. Maybe no errors should have been reported.

### Output of `rpm-ostree status`

```shell
rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
  ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:latest
                   Digest: sha256:e28ebeb8c5a04afa37a2302749691d13911fde6996912b21560d1747f81bf188
                  Version: 39.20231207.0 (2023-12-07T20:34:53Z)

● ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:latest
                   Digest: sha256:e28ebeb8c5a04afa37a2302749691d13911fde6996912b21560d1747f81bf188
                  Version: 39.20231207.0 (2023-12-07T20:34:53Z)

  ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:gts
                   Digest: sha256:cef53a3b235ef7f7866c38f4c1d3e3cae9b143c7110acbac3164e57fa8e5b32b
                  Version: 38.20231206.0 (2023-12-07T20:36:24Z)

Extra information or context

No response

bobslept commented 12 months ago

Thanks for filing the issue.

Just seems to handle every non zero exit code as an error. In this case a no updates available gives us exit code 2, which for the program means, the run was successful but no actions needed to be taken. Because there are no new updates avaiable.

I've send in a PR to suppres the error from just.