ublue-os / fleek

[deprecated] Own your $HOME
https://getfleek.dev
Apache License 2.0
833 stars 24 forks source link

`Fleek init` asks for existing SSH key with no explanation if git creds not yet configured #236

Closed mtalexan closed 1 year ago

mtalexan commented 1 year ago

Describe the bug
No documentation or commands explain why an SSH is needed, but one is required to be present and selected during fleek init. Any moderately competent user will not provide this without explanation.

To Reproduce
fleek init

Expected behavior
Any explanation in documentation or (even better) as part of the command that explains the purpose or expectations of the SSH key. Bonus points for explaining the also seemingly unnecessary "name" and "email" that are also requested.

Environment

Additional context

From a blog-like mention of the history of fleek, there's a passing reference to ssh-age as a source of inspiration. Since that's almost the only mention of SSH anywhere in the entire fleek repo, I dug into it. It appears ssh-age is used to encrypt secrets on the client using an SSH key so they can be stored encrypted in a publicly visible cloud storage, but there's also no mention at all of secrets anywhere in fleek.

mtalexan commented 1 year ago

If git credentials (user.email and user.name) haven't yet been configured, it doesn't say "git email", it just says "email" when prompting. The SSH key request seemed to not include the term "GitHub" either, but I'm unable to replicate that now that I've set the git config the first time on the system (even if I got back and unset them).

Closing this as a mistake on my part.