search

ublue-os / framework

OCI Images derived of ublue-os main images for Framework hardware
https://universal-blue.org/images/framework
Apache License 2.0
13 stars 2 forks source link

Just recipe does not add grub parameters #62

Open bmp opened 4 months ago

bmp commented 4 months ago

The just recipe currently for framework, i.e just framework-13 does not add the grub parameters. This can be verified by running just framework-13, there is no message/output that suggests we should run systemctl reboot. In order to check, we can reboot, and check both, in grub and when logged in with rpm-ostree kargs, the parameters are not set.

However, when you run the same command that is in the recipe, rpm-ostree kargs --append="module_blacklist=hid_sensor_hub" or any variation that you would run will result in the rpm-ostree being rebuilt and a message being displayed that we should reboot and the parameters are set.

I was able to replicate this on two VMs and on my laptop (on a fresh install and previously when I was rebasing between kinoite-framework and bluefin-dx-framework) .

bobslept commented 4 months ago

What is your cpu model? The grub parameters are currently set based on the cpu model refered to the documentation of framework. They currently should be set for 13 and 12th gen intel cpu models. You can get the cpu model by grep -m 1 "model name" /proc/cpuinfo. Does that display a 12 or 13th gen intel cpu?

See https://github.com/ublue-os/framework/issues/44 for more information.

bmp commented 4 months ago

Oops, should have mentioned that in the post, here is the output for grep -m 1 "model name" /proc/cpuinfo,

model name : 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz

bmp commented 4 months ago

@bobslept Based on my ouput of my cpuinfo shouldn't rpm-ostree kargs --append="module_blacklist=hid_sensor_hub" run acording to the recipe?

bobslept commented 4 months ago

@bobslept Based on my ouput of my cpuinfo shouldn't rpm-ostree kargs --append="module_blacklist=hid_sensor_hub" run acording to the recipe?

Based on your cpu info it will do nothing. The line you refering to is executed on a 12th gen intel cpu, based on the elif grep -q "12th Gen" <<< $CPU_MODEL.

I checked the framework docs here and they don't mention any kernel options needed to be set. So I think they are not needed on 11th gen.

bmp commented 4 months ago

Interesting, the one for 11th Gen Fedora 37, there seems to be a suggestion for NVME and one for freezing.

Does this mean we do not need this anymore for Fedora 38, 39 etc.?

bmp commented 3 months ago

Just checking if anyone else is looking at this?