ublue-os / isogenerator

Creates an ISO for installing a container image as an OS
Apache License 2.0
15 stars 2 forks source link

chore: remove dnf cache and unused files from built image #26

Closed p5 closed 8 months ago

p5 commented 8 months ago

We should remove dnf cached files from the image before publishing it. Also we don't need to include files like the devcontainer config or action.yml in the image, so only including the necessary files.

noelmiller commented 8 months ago

entrypoint.sh also needs to be copied over. I'm starting to think saving space on the action.yml, LICENSE file, README.md, and Containerfile isn't worth the hassle of continuing to add files to the list of things copied into the container.

@bsherman thoughts?

p5 commented 8 months ago

entrypoint.sh also needs to be copied over. I'm starting to think saving space on the action.yml, LICENSE file, README.md, and Containerfile isn't worth the hassle of continuing to add files to the list of things copied into the container.

Have switched to a .dockerignore instead. That way, we are including files by default, instead of the previous way of excluding them by default.

p5 commented 8 months ago

:facepalm: I cancelled the builds in the wrong tab. Will rerun them.
Sorry