search

ublue-os / main

OCI base images of Fedora with batteries included
https://universal-blue.org/images/main/
Apache License 2.0
489 stars 43 forks source link

[FEAT] set no-install-recommends by default across ublue #632

Closed qoijjj closed 1 month ago

qoijjj commented 1 month ago

As of rpm-ostree 2024.7, this is available:

https://github.com/coreos/rpm-ostree/pull/4974

castrojo commented 1 month ago

Can we figure out a way to see what would be dropped on the images when using this?

I'd love to have this on but don't want to wake up one day and a tool someone depends on is missing without giving people a heads up.

qoijjj commented 1 month ago

@castrojo For sure, I'm testing it now. Gonna generate a set of main images with my patched config, then rebase between the two and see what the delta is.

That will only get us part of the way there though, since this will affect every rpm-ostree install call across all of ublue, from main to hwe to bluefin to bazzite

castrojo commented 1 month ago

Yeah if you wouldn't mind documenting the steps we could spread the work, as I'm sure custom image builders would want to know how to check. Thanks!

qoijjj commented 1 month ago

interesting findings so far:

image image

This means that either none of the packages installed in ublue-os/main have any recommends (which seems unlikely) or rpm-ostree being called in packages.sh is ignoring the rpm-ostreed.conf installed into the image earlier in the containerfile.

@castrojo do you know which config file rpm-ostree reads from when called from the containerfile inside buildah?

KyleGospo commented 1 month ago

interesting findings so far:

image image

This means that either none of the packages installed in ublue-os/main have any recommends (which seems unlikely) or rpm-ostree being called in packages.sh is ignoring the rpm-ostreed.conf installed into the image earlier in the containerfile.

@castrojo do you know which config file rpm-ostree reads from when called from the containerfile inside buildah?

It's ignored, found that a few months ago when I built rpm-ostree and upgraded mine to test this.

Still considered for the end user.

qoijjj commented 1 month ago

It's ignored, found that a few months ago when I built rpm-ostree and upgraded mine to test this.

why is it ignored? and how can we make it not? :smile:

qoijjj commented 1 month ago

it's ignored because rpm-ostreed isn't running because systemd isn't:

System has not been booted with systemd as init system (PID 1). Can't operate.
qoijjj commented 1 month ago

tried rpm-ostree reload and rpm-ostree start-daemon

neither works because the daemon can't be run from inside the container.

@castrojo @KyleGospo I think we can just go ahead and merge the rpm-ostreed.conf change. It won't do anything in our builds, but it will affect local user layers which is better than nothing

fiftydinar commented 1 month ago

I know some Gnome extension recommends Gnome Extensions app as an example

Very dirty if you have Extension Manager already installed