search

ublue-os / ublue-update

Small maintenance/update program written in python intended for use in Universal Blue
Apache License 2.0
10 stars 17 forks source link

Better Defaults for Downstreams #129

Open gerblesh opened 3 months ago

gerblesh commented 3 months ago

The ublue-update defaults have shown to be not ideal for downstream. Issues with battery checks in psutil means that the battery percentage check is broken and often needs to be disabled (https://github.com/ublue-os/ublue-update/issues/79), and both Bluefin and Bazzite set similar defaults in the ublue-update.toml file:

Notably both disable dbus_notify meaning a large portion of the codebase is not being used downstream. For this I want to have an open discussion about creating better, more preferred defaults for downstreams and also discuss the potential removal or revamp of dbus notifications in ublue-update

fiftydinar commented 3 months ago

dbus_notify should be false by default imo. It's still an useful function, so I think that it shouldn't be removed, but refactored.

I thought that psutil thing is fixed by using downstream patch.