search

ublue-os / ucore

An OCI base image of Fedora CoreOS with batteries included
https://projectucore.io
Apache License 2.0
115 stars 23 forks source link

feat: Add rclone package to ucore build for mounting cloud storage #125

Closed dylanmtaylor closed 2 months ago

dylanmtaylor commented 5 months ago

This pull request adds rclone, a single 20MB package with no dependencies and adds an entry to the readme. Being in the base image is needed as mounting remote storage does not work from within a container. https://rclone.org/commands/rclone_mount/

dylanmtaylor commented 5 months ago

For my usecase, I was able to get backup working with the lscr.io/linuxserver/duplicati:latest container. If you do want to actually mount a remote filesystem as a directory though, you'll need to layer on rclone.

dylanmtaylor commented 4 months ago

I would love to also have restic, but this one is really the one that doesn't work right unless it is in the base image or layered on.

dylanmtaylor commented 4 months ago

A similar change was accepted in bluefin. https://github.com/ublue-os/bluefin/commit/49c4669f1852d19e179b5118bd2f2997fd8c44bb

johnmmcgee commented 4 months ago

I second this for ucore and ucore-hci

bsherman commented 2 months ago

I think it's reasonable to add rclone given it's role in mounting filesystems. That's consistent with other tools we've added to the image.

To be overly clear for future readers, the PR does already have this package in the correct place, but this is specifically going into ucore not ucore-minimal.

dylanmtaylor commented 2 months ago

Please remove restic, but rclone can stay and will be merged.

Done. Although I am still a huge fan of restic and wouldn't mind it being in by default in the future. :)

bsherman commented 2 months ago

Done. Although I am still a huge fan of restic and wouldn't mind it being in by default in the future. :)

Duly noted. :smiley:

dylanmtaylor commented 2 months ago

I just updated the list to touch nothing but rclone.

bsherman commented 2 months ago

I just updated the list to touch nothing but rclone.

Thank you.

We do have some best practice guidelines for PRs.

One thing I personally emphasize is that a PR is single purpose. So adding rclone, great, do it right, sorted into the right location. But don't add other formatting, sorting, or any other changes.

That's what's driving my recent feedback here.