ublue-os / ucore

An OCI base image of Fedora CoreOS with batteries included
https://projectucore.io
Apache License 2.0
155 stars 32 forks source link

feat: add ucore copr repo and install sanoid #131

Closed johnmmcgee closed 6 months ago

johnmmcgee commented 6 months ago

/tmp/install-ucore.sh: line 6: ZFS_TAG: unbound variable

bsherman commented 6 months ago

inspection of the spec file itself to see what it's doing. Instead of inspecting the spec file, i just started rpm-ostree uninstalling packages in a container running this image.

I think one main issue is simply that the spec file requires perl which pulls in all the compiler stuff. Fedora CoreOS doesn't install the perl package, rather it installs perl-interpreter which provides perl without the C compiler baggage.

This tells me we will likely need to host our own spec file for sanoid with slimmer deps, and then build THAT spec file in COPR.

Honestly, not too shocking considering sanoid doesn't build their own RPM.

bsherman commented 6 months ago

We merged https://github.com/ublue-os/packages/pull/16 to cleanup the dependencies pulled in by sanoid.

Now in COPR we had a problem: https://download.copr.fedorainfracloud.org/results/ublue-os/ucore/fedora-39-x86_64/07189025-sanoid/builder-live.log.gz

Relevant bit seems to be:

+ /usr/lib/rpm/rpmuncompress -x /builddir/build/SOURCES/sanoid-2.2.0.ucore1.tar.gz
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd sanoid-2.2.0.ucore1
/var/tmp/rpm-tmp.2DGIv5: line 41: cd: sanoid-2.2.0.ucore1: No such file or directory

So, the change of version isn't messing with the tarball.

Need to determine if we can fix this or just need to ship the stock version.

johnmmcgee commented 6 months ago

My opinion is just stock version since Release will be set to fedora and this is fedora.