search

ublue-os / ucore

An OCI base image of Fedora CoreOS with batteries included
https://projectucore.io
Apache License 2.0
115 stars 23 forks source link

feat: add cockpit-zfs-manager for zfs builds #145

Open Eelviny opened 3 months ago

Eelviny commented 3 months ago

Long time lurker, first time contributor. This PR adds https://github.com/45Drives/cockpit-zfs-manager to ZFS builds of ucore-minimal.

You may notice that this repo actually provides .rpm builds and I wanted to use that, however those builds have a hard dependency on ZnapZend making it not easily usable. I instead opted to pull the release tar. I'm unsure whether locking to a specific version in this way is the best and feedback would be appreciated here.

I've tested these changes by creating an rpm-ostree usroverlay and running the commands manually, but unsure how best to properly integration test.

Eelviny commented 3 months ago

Just noticed that there is an issue open already for this, fixes #100

bsherman commented 2 months ago

Long time lurker, first time contributor. This PR adds https://github.com/45Drives/cockpit-zfs-manager to ZFS builds of ucore-minimal.

You may notice that this repo actually provides .rpm builds and I wanted to use that, however those builds have a hard dependency on ZnapZend making it not easily usable. I instead opted to pull the release tar. I'm unsure whether locking to a specific version in this way is the best and feedback would be appreciated here.

I've tested these changes by creating an rpm-ostree usroverlay and running the commands manually, but unsure how best to properly integration test.

Last time I tested the cockpit-zfs-manager there were some significant downsides... broken icons, broken javascript, etc...

It's pretty obvious we don't have formal requirements for integration testing, but the fancier a tool is the more cautious I am. :grinning:

One thing we could do, add some logic to the build process to ONLY add certain things to the testing images.

For example, I am hesitant to add this to stable, but it could be in testing to give people a chance to try it out.

Thoughts about this?

Eelviny commented 2 months ago

Yep, I tried it and there's definitely still broken icons etc. 45drives is basically keeping it on life support after it got abandoned by the creator.

However in terms of functionality, it's still working fine. I've gotten into the habit of putting this into a usroverlay every time I need to make changes to the zpool, just put in a PR because I thought it might be a good idea but I can understand if it's not quite at the level of quality you'd want to have.

testing image sounds great.