search

ubnt-intrepid / dot

Yet another management tool for dotfiles
MIT License
227 stars 11 forks source link

upgrade to Rust 2018 #18

Closed ubnt-intrepid closed 4 years ago

ingorichter commented 4 years ago

I compiled it with 1.38.0 and made a small change to get rid of the warnings. My changes are here https://github.com/ingorichter/dot. Is there anything else?

ubnt-intrepid commented 4 years ago

If there is no package.edition in Cargo.toml, Cargo sets the edition to 2015 for compatibility. In order to use the edition 2018 explicitly, we need to set edition = "2018". When the edition is upgraded, the build will probably fail caused by errors around module resolution.

Here is a guide for the transition to Rust 2018.

ingorichter commented 4 years ago

Okay, that makes more sense now ;-) I didn't know about the edition field. And now I can see the errors. Thanks for clarifying that. I'm going to resolve some of these issues.

ingorichter commented 4 years ago

@ubnt-intrepid I have a PR that enables Rust 2018 support