search

ubports / account-plugins

Moved to https://gitlab.com/ubports/core/indicator-transfer
https://gitlab.com/ubports/core/indicator-transfer
GNU General Public License v2.0
3 stars 6 forks source link

Remove unnecessary dependencies #14

Closed jonnius closed 6 years ago

jonnius commented 6 years ago

Removed vala, gnome-common, python4, introspection dependencies and files. With this commit, crossbuilder can be used to build the packages. Fixes #13

Should this go to xenial or master branch?

jonnius commented 6 years ago

I removed them.

mardy commented 6 years ago

Thanks! Can you please add one more commit, where you bring in this Jenkinsfile: https://github.com/ubports/build-tools/blob/master/Jenkinsfile ? CI is failing, and I think that this could fix it.

jonnius commented 6 years ago

Unfortunately that didn't fix it. It just reenabled arm64, which has been disabled recently by @Flohack74 (#9, see the commit) due to jenkins failing to build that. Therefore, I removed the commit again...

mardy commented 6 years ago

Yes, I've seen that the arm64 build was disable, but I suspect that this is the cause why the later parts of the build are failing :-) So, we should enable the arm64 build and try to find out why it fails, and fix it.

Do you have a log for the failed build? I can't seem to be able to find it in Jenkins.

jonnius commented 6 years ago

Weird, it still does not build for arm64...

mardy commented 6 years ago

@Flohack74 why did you merge this? We were still investigating why the build fails in CI :-) Anyway, no need to revert: we can add the fix in another MP.

mardy commented 6 years ago

Actually, it looks like CI is working fine now, in the xenial branch :-)

Flohack74 commented 6 years ago

@mardy Dont pannick, I was almost confident it will work - nah had no idea, but sometimes doing gives more chances to solve stuff than just pondering xD