search

ubports / account-plugins

Moved to https://gitlab.com/ubports/core/indicator-transfer
https://gitlab.com/ubports/core/indicator-transfer
GNU General Public License v2.0
3 stars 6 forks source link

Use the external browser for Google authentication #45

Closed mardy closed 2 years ago

mardy commented 3 years ago

This MR depends on https://github.com/ubports/ubuntu-system-settings-online-accounts/pull/16

This fixes: https://github.com/ubports/account-plugins/issues/40, at the cost of making the authentication flow less user-friendly (but this is what Google explicitly asks us to do).

UniversalSuperBox commented 3 years ago

I've noticed that there is no button to close the new Google account interface.

image

If the user navigates back to system-settings without completing the login, they are unable to leave the Google login due to this.

mardy commented 3 years ago

Blocking review due to ^

I added a Cancel button now, but I'm unable to test it. Will you please give it a try?

amartinz commented 2 years ago

Dependency has landed.

amartinz commented 2 years ago

Tested with logging in a family link enabled account (so had to log in the account as well as logging in a second time with the parent account).

Cancel button is there as well and is functional :smile: