search

ubports / apparmor-backports-ut

AppArmor backports for Ubuntu Touch
1 stars 2 forks source link

apparmor 4 patch #2

Open grotius-cnc opened 3 years ago

grotius-cnc commented 3 years ago

Hi,

Following this guide : https://github.com/Halium/projectmanagement/issues/48#issuecomment-626908532

When extracting the apparmor 4 patch, compilation give's error. When only extracting apparmor 3 patch, no error so far.

Flohack74 commented 3 years ago

You need to fix the compile error, instead of using a different patchset. Each one is made for the respective kernel. I will upload the patch into the repo, but so far it will not save you from manual corrections. Thats the nature of those patches, all Android kernels could be slightly different, we cannot provide a version that works for all.

Flohack74 commented 3 years ago

See also https://github.com/ubports/apparmor-backports-ut/blob/master/README.md#use-correct-version-for-your-kernel

grotius-cnc commented 3 years ago

Hi,

Thanks for your information.

Through your readme file, i had installed the 4 patches all together.

Maybe add a extra argument to the readme file, that it is clear for users only apply one patch, for a certain kernel version.

It would be nice to add a $ command line argument that returns the kernel version.

Thanks so far !

P.s. You can query your kernel version from the Makefile file in the top level of the checked out code. I don't understand where to find this at the moment in the halium directory structure. Can you give me a hint or filepath?

Compiled mka halium-boot + mka systemimage succesfull so far, but i have to check kernel version as you suggested.

Flohack74 commented 3 years ago

Please check kernel//<device/common name>/Makefile in your tree ;)