Lighter colors for calendars

ubports / calendar-app

Moved to GitLab

https://gitlab.com/ubports/apps/calendar-app

GNU General Public License v3.0

6 stars 9 forks source link

Lighter colors for calendars #149

Closed cibersheep closed 5 years ago

cibersheep commented 5 years ago

Might fix #148

hummlbach commented 5 years ago

Would be cool if you could replace the color picker with another one instead of some colors in it s.t. #109 would be also fixed...(?) ;-)

cibersheep commented 5 years ago

Yep. That would be nice. Let's see how this behaves first :) as I don't know how the colors are passed to the indicator.

Have you done any try?

bhdouglass commented 5 years ago

@hummlbach what's the status of this?

cibersheep commented 5 years ago

@bhdouglass There's two different issues here. The feature requested has tangencial relation with this fix :)

bhdouglass commented 5 years ago

Gotcha, then can we get this merged in?

cibersheep commented 5 years ago

I think we might (as it proposes a fix to an specific issue we have now) and keep an eye to the selector idea which I think is very interesting but it will take more time and more skills

bhdouglass commented 5 years ago

That makes sense to me, lets fix the issue we have and implement a color picker later. What do you think @hummlbach ?

hummlbach commented 5 years ago

In principle I'm fine with the change. two remarks on it:

for the light theme the text on the events is white, so the colors shouldn't be too light. But the ones you chose are just fine ofc
if we're changinge the colors in the picker now we could also change the red or the orange, since I can hardly see a difference between them...(?) Adding some pictures. New palette: Old palette: But also we don't need to do it now necessarily .

bhdouglass commented 5 years ago

@cibersheep are you getting these colors from the ubuntu color pallet?

cibersheep commented 5 years ago

@hummlbach I think when we go into a color pick, it could be a «free» color pick, something like Mateo Salta did for Webapp Creator. And be able to choose any color. I don't know if it's feasible though as I don't know if the colors are stored somewhere (between app and indicator). @bhdouglass I got the colors from the palette and used the ones I changed from the contacts app :)

bhdouglass commented 5 years ago

:+1: we should probably stick to the pallet until we add a color picker. Is the one in the webapp creator something that we could reuse here? No sense in reinventing the wheel. (I know that off topic for this PR)

cibersheep commented 5 years ago

@bhdouglass so we are safe as I used the colors in the palette. The webapp creator picker code is something we could use easily, yes.

hummlbach commented 5 years ago

Maybe we could make a call for examples for existing color pickers in ut apps... and choose the nicest...(?)

bhdouglass commented 5 years ago

@cibersheep sounds good, then it makes sense to me to merge this and investigate reusing the code from the webapp creator.

@hummlbach that's definitely something that could be kicked around in the design channel(s)

cibersheep commented 5 years ago

@bhdouglass (I thought I answered this already, but not too many tabs opened :D) We can reuse the Webapp Creator for sure, what we need also to investigate is how to store the color info (if possible)

UniversalSuperBox commented 5 years ago

So... is this approved and ready for merge then? :)

bhdouglass commented 5 years ago

Yes this is just pending @hummlbach hitting the merge button.

hummlbach commented 5 years ago

Sorry. Done. ^^