search

ubports / camera-app

Moved to GitLab
https://gitlab.com/ubports/apps/camera-app
GNU General Public License v3.0
10 stars 9 forks source link

xenial_constexpr #75

Closed nfsprodriver closed 6 years ago

nfsprodriver commented 6 years ago

Well xenial really seems to need constexpr at this point to get built so I think we should merge this.

nfsprodriver commented 6 years ago

Hm, needs some further fixes. Maybe we can replace the constexpression by some other values of a different type?

dark-eye commented 6 years ago

Maybe just create a general xenial branch if there's are required code differences? just going wild here...... maybe theres a way to detect the target at compile time and select the correct code/files so we can have a single code base...

nfsprodriver commented 6 years ago

How can we tell jenkins to use std c++11 (or something like that)?

dpniel commented 6 years ago

@nfsprodriver you do it in cmake set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")

Also your branch name is wrong to get it to build against xenial. It should be xenial_-_constexpr (weird i know... blame jenkins!)

nfsprodriver commented 6 years ago

@dpniel Thank you! I'll recreate that PR...