search

ubports / crossbuilder

A debian package cross building tool using LXD
13 stars 17 forks source link

Improvements for dependencies installation #35

Closed peat-psuwit closed 4 years ago

peat-psuwit commented 4 years ago

This PR contains 2 improvements to crossbuilder dependencies installation.

The first one is the usage of --no-install-recommends in dependencies resolving. This helps reduce unnecessary dependencies. It also helps work around a bug in apt that causes it to remove packages for the sake of installing recommended packages.

The second one is the complete removal of source repository creation. Source package repository was used to allow "apt-get build-dep" to be used. However, now that we use mk-build-deps, there's no need to use source repository anymore.

mardy commented 4 years ago

The second commit doesn't work for me, I get:

...
Get:45 http://archive.ubuntu.com/ubuntu xenial-security/main amd64 Packages [784 kB]                                                                                                                         
Get:46 http://archive.ubuntu.com/ubuntu xenial-security/main Translation-en [302 kB]                                                                                                                         
Get:47 http://archive.ubuntu.com/ubuntu xenial-security/universe amd64 Packages [465 kB]                                                                                                                     
Get:48 http://archive.ubuntu.com/ubuntu xenial-security/universe Translation-en [191 kB]                                                                                                                     
Get:49 http://archive.ubuntu.com/ubuntu xenial-security/multiverse amd64 Packages [5724 B]                                                                                                                   
Get:50 http://archive.ubuntu.com/ubuntu xenial-security/multiverse Translation-en [2708 B]                                                                                                                   
Fetched 10.9 MB in 13s (787 kB/s)                                                                                                                                                                            
Reading package lists... Done
W: The repository 'file:/home/mardy/source_repository  Release' is not signed.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
mk-build-deps: You must have equivs installed to use this program.
peat-psuwit commented 4 years ago

Are you sure it's due to my commit? The message about "repository not signed" is not actually an error. The actual error is that equivs is not installed, and basic dependencies installation has been refactored a few commits ago.

mardy commented 4 years ago

Are you sure it's due to my commit? The message about "repository not signed" is not actually an error. The actual error is that equivs is not installed, and basic dependencies installation has been refactored a few commits ago.

You are right: I did not create a new container, but used an older one which had been created before the refactoring. Thanks!