Syntax, structure, indent and unneeded logic fixes

[jezek]

• Fix unset usage.
• Fix some missing -e in echo where needed.
• Add some echos, before running some commands.
• Minor alignment fixes.
• Don't use 'newgrp' upon lxd install, seems to have no effect.
• Unify command output redirection formatting.
• Make some multi-line commands to be in one line.

[jezek]

@mardy So what about this PR? In meantime I've got one another approval. It seems, that @violethaze74 is OK (or doesn't care) about the split line merging.

[mardy]

@mardy So what about this PR? In meantime I've got one another approval. It seems, that @violethaze74 is OK (or doesn't care) about the split line merging.

Since this has been waiting for so long and that other contributors haven't voiced their opinion, I guess I'll just pick the changes that I like :-)

[jezek]

...other contributors haven't voiced their opinion, I guess I'll just pick the changes that I like :-)

I'm asking all contributors for this project (@fkaleo , @peat-psuwit , @fredldotme , @UniversalSuperBox , @jld3103 , @lduboeuf ), please read through our conversation (and this one too) and express your opinions and/or vote.

What to vote for? Basicaly it is about line wrapping. My opinion is that that the 3 lines shouldn't be split, because:

• No other line in the whole script is split after a pipe (|).
• There are more longer lines (some of them introduced @mardy by himself), that are not split, so why this.
• More uniform/consistent code is less distractible when reading through it.
• Avoid formatting changes result in more messy code, that is hard to read.
• Most editors have a (intelligent) long line wrapping feature, but none (that I know) has a split line merging feature.
• Hard split lines occupy more vertical space. Today's monitors are more wider than higher and vertical space is scarce. So if you have lines split manually, there is less code to read without scrolling.

What are your opinions about the split lines merging in this PR? What are your personal preferences for splitting lines manually (what is the maximum line length you allow in your code, after which you hard-split lines)?

I'm asking @mardy to wait until the end of January. After this month passes and there is no another vote/opinion (or the vote is a draw), I myself will revert the incriminating split lines merging (but fix the indentation).

Thank you all for your time and understanding.

[lduboeuf]

My opinion: I don't care about conditions writen in one-line. In some cases it is even more readable. Of course not 200 chars long but < 100 is acceptable

[jezek]

@mardy From my perspective I've got an approval from a contributor to merge this, as it is. :wink: What's your understanding of the comment above?

[mardy]

@mardy From my perspective I've got an approval from a contributor to merge this, as it is. wink What's your understanding of the comment above?

I've stated my opinion before, I think it's clear enough. If you want me to merge it, please do not change existing lines to make them longer; that said, I'm certainly not going to start a fight if someone else merges your contribution in its current form. :-)