ubports / docs.ubports.com

UBports Documentation
https://docs.ubports.com
72 stars 129 forks source link

docs: Add generic standalone kernel porting method #558

Closed muhammad23012009 closed 6 months ago

doniks commented 1 year ago

Hey. Thanks for starting on H10. I haven't read everything in detail but allow me to share one thought quickly right away: Is all of this really specific for 10? It doesn't seem like to me. I got the impression there is a lot of added info. E.g., how to go look for a device tree, but this applies to every android version. Other parts I'm wondering whether this will be a lot of duplication between 9 and 10. It would be better to have common parts in a common section and only highlight version specific parts per Android version.

Let me know what you think

muhammad23012009 commented 1 year ago

Hi! Thanks for your reply. I thought about the device-tree bit, but that was only for if somebody needed to find it on the spot. It could be added to a common document nonetheless. Everything else was written from scratch and not copied from anywhere, and the deviceinfo parts are important since halium-9.0 doesn't support most of them I believe.

doniks commented 1 year ago

I thought about the device-tree bit, but that was only for if somebody needed to find it on the spot. It could be added to a common document nonetheless.

I think it is very helpful! Wrt common doc, I'd say

NotKit commented 1 year ago

I think it should be just called a Ubuntu Touch porting method for Treble devices (Android 9-11, soon 12) without reference to specific Halium version in the title, as it will confuse people. Currently it applies to Halium from 9 to 11.

doniks commented 1 year ago

ping

doniks commented 7 months ago

I'm conflicted with this PR. there was no followup for a year, but a) it seems to me there are generic (not just H10) additions in here and b) documenting newer halium versions would be very useful, however the review is still open

But in case anyone sees this here. Do not hesitate to make your own alternative pr to update Halium docs, just because this PR is open. It seems very much dormant.

muhammad23012009 commented 7 months ago

I'm conflicted with this PR. there was no followup for a year, but a) it seems to me there are generic (not just H10) additions in here and b) documenting newer halium versions would be very useful, however the review is still open

But in case anyone sees this here. Do not hesitate to make your own alternative pr to update Halium docs, just because this PR is open. It seems very much dormant.

It isn't all that dormant. I've been working on new additions for this PR, making everything generic and adding much more information about the current porting method. I just need a bit of time to complete it, hopefully should be done by the first week of April :)

doniks commented 7 months ago

Awesome!

muhammad23012009 commented 7 months ago

Awesome!

I have updated the docs and pushed again.

NotKit commented 7 months ago

For @doniks: we discussed with @muhammad23012009 that Halium 9 section should be completely dropped/replaced due to being no longer relevant in overall.

doniks commented 7 months ago

Thanks for sticking with it @muhammad23012009 . Did you see that it fails to build: https://ci.ubports.com/blue/organizations/jenkins/docs.ubports.com/detail/PR-558/21/pipeline I think you need a redirect https://docs.ubports.com/en/latest/contribute/documentation.html#moving-pages

muhammad23012009 commented 7 months ago

Thanks for sticking with it @muhammad23012009 . Did you see that it fails to build: https://ci.ubports.com/blue/organizations/jenkins/docs.ubports.com/detail/PR-558/21/pipeline I think you need a redirect https://docs.ubports.com/en/latest/contribute/documentation.html#moving-pages

Done.