ubports / installer-configs

Install configurations for the UBports Installer
https://github.com/ubports/ubports-installer
GNU General Public License v3.0
57 stars 76 forks source link

axolotl: remove unlock steps, verify recovery, implement fastbootd user action #180

Closed amartinz closed 2 years ago

amartinz commented 2 years ago

I just got a failure trying to assert recovery with 0.9.5-beta:

verbose: running adb action assert_prop
error: Error: adb:assert_prop: Error: unknown getprop error
stack trace: Error: unknown getprop error
    at /tmp/.mount_ubportL2xeIJ/resources/app.asar.unpacked/node_modules/promise-android-tools/lib/module.cjs:565:21
    at /tmp/.mount_ubportL2xeIJ/resources/app.asar.unpacked/node_modules/promise-android-tools/node_modules/cancelable-promise/dist/CancelablePromise.js:27:18
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Edit: I am stupid. I forgot to update the prebuilt recovery used by the installer, which includes ro.ubports.recovery instead of ro.ubuntu.recovery.

amartinz commented 2 years ago

updated prebuilt recovery, which fixes above assertion error and installs successfully.

open-cuts report: https://ubports.open-cuts.org/run/623de8a4bfb7110008fb5360

NeoTheThird commented 2 years ago

I forgot to update the prebuilt recovery used by the installer, which includes ro.ubports.recovery instead of ro.ubuntu.recovery.

But which will be used in the wild?

amartinz commented 2 years ago

I forgot to update the prebuilt recovery used by the installer, which includes ro.ubports.recovery instead of ro.ubuntu.recovery.

But which will be used in the wild?

the one specified in installer only.