search

ubports / installer-configs

Install configurations for the UBports Installer
https://github.com/ubports/ubports-installer
GNU General Public License v3.0
57 stars 76 forks source link

fastboot:flashing_unlock does not handle code_url #183

Open amartinz opened 2 years ago

amartinz commented 2 years ago

fastboot:oem_unlock: allows providing a code_url to specify a link to follow for instructions regarding how to obtain a code to unlock the bootloader.

fastboot:flashing_unlock: does the same as fastboot:oem_unlock: but does not allow providing a code_url according to action.schema.yml.

NeoTheThird commented 2 years ago

Is it even possible to supply a code to it? Maybe we simply haven't had a device that used flashing unlock and needed a code yet.

amartinz commented 2 years ago

I wanted to abuse that feature to show a link with instructions of how to unlock the bootloader.

so maybe should be renamed to link to match existing actions allowing to open an url?

NeoTheThird commented 2 years ago

That would be useful. But cave: That is not all that code_url does for fastboot:oem_unlock. It actually expects the user to obtain and enter a code. On devices that do not need that code, it would not work. So we should implement an instructions link for both of them.