search

ubports / keyboard-component

Moved to https://gitlab.com/ubports/core/lomiri-keyboard
https://gitlab.com/ubports/core/lomiri-keyboard
GNU Lesser General Public License v3.0
10 stars 36 forks source link

add Emoji as a layout #129

Closed Fuseteam closed 3 years ago

Fuseteam commented 4 years ago

this pull request adds the emoji layout to the languages folder with a couple of modifications. These modifications are allow switching to it to function like the symbols keyboard this does not add an new interaction to actually switch to emoji nor does it remove emoji from the list of languages

feedback regarding what is needed to get this merged in is appreaciated

Fuseteam commented 4 years ago

@UniversalSuperBox feedback please (when you have time)

Fuseteam commented 3 years ago

this should make it possible to remove ubunut-keyboard-emoji as a package and still switch to the emoji keyboard from the language menu

Fuseteam commented 3 years ago

the mr to actually remove the old emoji "layout" is here: https://gitlab.com/ubports/core/seeds/ubuntu-touch/-/merge_requests/26

UniversalSuperBox commented 3 years ago

I was able to force the system to downgrade to the keyboard version that's expected by this PR (the ongoing rebuild should help that) and got the emoji keyboard running. However, my settings still include the old Emoji plugin, which won't load.

The Emoji layout can be switched to and works fine.

UniversalSuperBox commented 3 years ago

This is my current layout switcher

image

Fuseteam commented 3 years ago

that's weird it shouldn't show up anymore, it doesn't for me anyway. maybe i need to reset and retest

Fuseteam commented 3 years ago

hmm it is indeed still visible, i'm not sure what more i can do to remove it

Fuseteam commented 3 years ago

uhhh somehow the emoji layout entry is no longer visible on my device but i didn't touch the keyboard code, not sure if its a restart or something that fixed it

Fuseteam commented 3 years ago

As a control case i removed the emoji keyboard without installing the PR and rebooted

And its still listed...........

peat-psuwit commented 3 years ago

Hello,

Thank you for contributing to UBports. As part of project renaming and the effort to port Ubuntu Touch stack to Ubuntu 20.04, we're incrementally migrating repositories to GitLab.

Your PR is now migrated to: https://gitlab.com/ubports/core/lomiri-keyboard/-/merge_requests/N However, you might not be able to push new code into it, as the branch resides in our repository. In case you need to update it, please open a new MR from your (new) fork. I don't have a better solution at the moment.

Sorry for your inconvenience.