ubports / morph-browser

Moved to https://gitlab.com/ubports/core/morph-browser
https://gitlab.com/ubports/core/morph-browser
GNU General Public License v3.0
45 stars 35 forks source link

Systematic crashes of morph-browser or webapp (webber) #341

Closed gbdomubpkm closed 4 years ago

gbdomubpkm commented 4 years ago

@balcy @UniversalSuperBox seen today with the last update in dev (OPO, BQ E5 HD..)

Steps to reproduce :

take this site for example : https://www.deepl.com

I hadn't seen this so systematically in a long time...

By performing the same manipulations on all web pages, all webapps where there is a writing area and keeping the keyboard visible, morph-browser or a webapp crashes at some point and usually very quickly.

balcy commented 4 years ago

Could this be a problem related to the upgrade of QtWebEngine and old cache still present ? Does it still crash after you do "Clear Cache" from the settings? There are reports with crashes on Qt upgrades for qutebrowser, too: https://github.com/qutebrowser/qutebrowser/issues/4853 I've seen more crashes myself when switching from Qt 5.13 to 5.14 or 5.11 to 5.14 We might need to ask the user or automatically clean the cache the first time a user uses morph or a webapp with new Qt.

But all of this this would not explain how the keyboard is involved in the problem. At least I cannot reproduce the crash on my BQ 4.5 right now.

balcy commented 4 years ago

there are even crashes that go away after 72 hours (Qt5.12 but could apply for 5.14) https://bugreports.qt.io/plugins/servlet/mobile#issue/QTBUG-72532

gbdomubpkm commented 4 years ago

More precisely try with deepl (web or webapp) with the steps and by sliding your finger on screen upwards. Clean cache change nothing for me.

balcy commented 4 years ago

ok, do you have to be logged in on the deepl page?

gbdomubpkm commented 4 years ago

No, free use. And it did the same thing now on my github webapp with the OSK visible. If the OSK not visible, no problem for me.

gbdomubpkm commented 4 years ago

.... and i confirm that you are right for the bq 4.5 : i don't see the problem !!! (dev 554). But yes on OPO, BQ E5 HD for me !

balcy commented 4 years ago

ah ok, that's the only device I have... (and Raspberry Pi 3) otherwise I could have tried if I see sth. with GDB

gbdomubpkm commented 4 years ago

Incredible that given the great services you provide to the community as a super developer, you only have the BQ 4.5, very good basic phone indeed !

balcy commented 4 years ago

yeah even have used it with dual sim for some years, hopefully it will keep running a few more months : ) Maybe @UniversalSuperBox can debug it (if he sees the bug), it would be interesting to know if it only appears in morph / webapp-container or in other QtWebEngine based browsers, too. E.g. if you clone https://gitlab.com/balcy/qt-webengine-demo/ and build it with clickable.

lduboeuf commented 4 years ago

got it today on N5 on Youtube webapps. Got a crash every time. Need to see if anything wrong with cache. But returnes to RC since...

balcy commented 4 years ago

@lduboeuf Do you see the crash on scrolling, or did it not load at all ? It might just be the missing env. variable then. (If the youtube webapp does use QtWebEngine directly)

gbdomubpkm commented 4 years ago

Me too, back to RC on my main phone BQ E5 HD as long as the problem is there : I lose one of the advantages of qt 5.14 (sign in/up again possible on GITLAB with UT smartphone) but there are no more crashes !!

balcy commented 4 years ago

I wanted to write how I usually debug QtWebEngine via morph:

lduboeuf commented 4 years ago

@lduboeuf Do you see the crash on scrolling, or did it not load at all ? It might just be the missing env. variable then. (If the youtube webapp does use QtWebEngine directly)

Crash at app load, i used that one: https://github.com/mateosalta/cuddly-bassoon

gbdomubpkm commented 4 years ago

Just for info, Nexus 5 is not spared by the crash when scrolling in dev (OSK apparent). Example:

balcy commented 4 years ago

good (or bad) news for BQ Aquaris 4.5 : When changing the scale in UT Tweak tool to 10 (original value is 12) I see the crash, too. Thread 29 "QSGRenderThread" received signal SIGSEGV, Segmentation fault. We might try how the version without the auto screen scale factor behaves.

balcy commented 4 years ago

this reproducable crash does not happen for me (even with that scale) with QTWEBENGINE_CHROMIUM_FLAGS="--disable-gpu" morph-browser --desktop_file_hint=unity8 only if --disable-viz-display-compositor is used. Then it is similar to the QtWebEngine 5.13 behavior. https://github.com/ubports/qtwebengine-opensource-src-packaging/issues/35

gbdomubpkm commented 4 years ago

Empirically tested (many restarts), i can say that i did not see any crashes for these scaling :

cibersheep commented 4 years ago

Ouh, I happen to test Dev from yesterday on E5

http://paste.ubuntu.com/p/vRKzFdqgKb/

This crash happened on webviews in qml files (Flas, uNav, etc) but not in html5 apps (Inoreader, Turtl, etc)

Do I need to test recent changes though

balcy commented 4 years ago

without the high DPI auto scale (branch https://github.com/ubports/morph-browser/tree/xenial_-_nohighdpiautoscale), the crash does not happen to me. So I suspect the crash happens in qtbase and is related to high DPI scaling.

cibersheep commented 4 years ago

On E5 20200720 fixed the issue. Is there something you want me to test?

gbdomubpkm commented 4 years ago

Back to dev on BQ E5 HD ! So no scrolling crash too only for scaling 16 and 17

MK1973 commented 4 years ago

I can confirm crashing also on FP2, N5, osk on and trying to scroll the window, perhaps.

ruedigerkupper commented 4 years ago

Confirming crashes on Xperia X (suzu).

lduboeuf commented 4 years ago

on BQ4.5, after several apps opened, did a search on github, tried to sort the result, qml select popup is displayed and don't remember if i got a unity8 restart by selecting one item or just before

gbdomubpkm commented 4 years ago

Tested BQ E5 HD : Fixed, not seen any new scrolling crashes. 👍

laborim commented 4 years ago

Device: oneplus 3 Channel: rc Build: 2020-W35/2

Seems fine. I can't reproduce the error

jezek commented 4 years ago

Device: FP2 Image: 2020-W35/2

Can't reproduce the issue.

AppsLee commented 4 years ago

Device: Nexus5 Image: 2020-W35/2

Cannot reproduce. Seems fixed to me.

peat-psuwit commented 4 years ago

Three confirmation. Considering solved.