search

ubports / morph-browser

Moved to https://gitlab.com/ubports/core/morph-browser
https://gitlab.com/ubports/core/morph-browser
GNU General Public License v3.0
45 stars 35 forks source link

Can't remove all text from search box. #92

Closed davidmattson1 closed 5 years ago

davidmattson1 commented 5 years ago

BUG-REPORT

Device: Nexus 5 Channel: Stable Build: OTA-5 Steps to reproduce Open Morph Browser Go to Google.com Search for 'Test' and search Try to remove all the text from the search box to search again. (Backspace 4 times) It shows Test in the search box again Expected behavior Allow me to remove all the text and leave it blank

Actual behavior Deleting all the text makes it show Test again

Logfiles and additional information Not sure that I can.

Note: I original opened this under the main project but I'm guessing this should go here.

balcy commented 5 years ago

it certainly has to to with the input method. There is currently one workaround: If you turn off "Spell checking" and "Word suggestions" in System Settings -> Language and Text, this does not happen. The input method seems not properly being reset when the last letter is deleted. Another workaround: before removing the last letter, click into the field again twice, so that the letter is no longer underlined, and then delete it. I'm not sure if we can solve this in morph properly, or if it is a problem of QtWebengine itself. Maybe we can call Qt.inputMethod.reset() when the keyboard opens to get rid of the problem

ruedigerkupper commented 5 years ago

Confirmed.

balcy commented 5 years ago

the problem is even a bit worse: If you are in a textarea, and press abc<Enter> and then <Backspace> you end up with aab, if you delete that you get abc again, which will reappear if you delete it.

And I've seen cases that allow the deletion of the whole text, but one more press on backspace will make the last word reappear. Actually we had some of those problems with Oxide too...

There are more cases like this, so it would not be enough to reset the input method when you enter a field.

balcy commented 5 years ago

for some reason the last remembered word is in some cases cached, where it should not be: e.g. for all examples only type the letters, not the < and > symbols!

UniversalSuperBox commented 5 years ago

It would probably be in our keyboard, in the autocorrect stuff. You remember correctly, this has been a problem since forever.

balcy commented 5 years ago

but with autocorrect enabled in the TextField / TextArea here https://open-store.io/app/qqc2-gallery.ubad it works fine. (the same example)

UniversalSuperBox commented 5 years ago

Right. And again, we had the same problem with Oxide. I'm not sure if it's Chromium or something above it, but you seem to be on the right track.

I've tried to file bugs with Qt before. They normally at least reply within a week. You may also want to hop onto IRC for QtWebEngine to ask about this.

balcy commented 5 years ago

Is it possible to test morph with any other on screen keyboard as reference ? What I've seen in the logs is, that every time a word is finished (e.g. after pressing space after the word) at the same time the word is no longer underlined, the following does appear in the log: Data set on unsupported clipboard mode. QMimeData object will be deleted. not sure if it is related. So the keyboard component might be the problem / part of the problem after all as you said... I think in the short term I can only think of a workaround like "Qt.inputMethod.commit()" before each backspace key press. (You loose the text prediction until you start the next word)

balcy commented 5 years ago

@oSoMoN you have much experience with Oxide and the webbrowser-app, right ? Would you think this is a QtWebEngine problem, or rather the ubuntu touch keyboard component ?

oSoMoN commented 5 years ago

Hard to tell without looking into it further, it could very well be that the problem requires fixes in both QtWebEngine and the keyboard component. We were definitely seeing similar issues with oxide and webbrowser-app.

cibersheep commented 5 years ago

@balcy is a little worse... as you can see in this issue Adress bar bug is fixed but you cannot tap on some OK buttons because of the predictive text getting in the way

balcy commented 5 years ago

there was a problem that the keyboard for special chars and numbers was reset to the letter view, that is fixed with https://github.com/ubports/morph-browser/pull/114

balcy commented 5 years ago

@cibersheep can you give an example of the problem with the OK buttons? Might the OK button be hidden because of https://github.com/ubports/morph-browser/issues/52 ?

cibersheep commented 5 years ago

Hey! I don't have my devices with Xenial with me until tomorrow but:

Does that help?

cibersheep commented 5 years ago

Sorry, @balcy as Dalton points, I have mixed an error occurring with native apps... so forgive me

balcy commented 5 years ago

that's alright, it sounded like sth. else in morph (text field) has a problem with the OK button.