search

ubports / telegram-app

Unofficial Telegram App for Ubuntu Desktop & Mobile
GNU General Public License v3.0
55 stars 23 forks source link

Restored optional support for message status indicators (tick icons) #201

Closed zubozrout closed 5 years ago

zubozrout commented 5 years ago

Hi @Flohack74, you wanted a pull request so I thought that since you updated the sources on GitHub to the latest version today I'd give it a try :).

Thank you :).

PS. Sorry for the duplicate of a closed request but I've accidentally closed the original pull request. Well, at least I've removed the .gitignore change with this one :).

Flohack74 commented 5 years ago

Hi, the patch is acceptable, except I would rename the option a bit like "Use classic message checkmarks" because indicator will not be clear to the people. Maybe this is already too long also, maybe we can have an even better idea.

zubozrout commented 5 years ago

Thank you, and yup, I agree with renaming it and like your idea too :). Well, I don't seem to be able to think of any feasible alternative to what you suggested so as far as I am concerned I'd go for it :).

Btw, how does the process work? Should I do the changes or will you accept them and update the value on your own? Also, there are two additional commits I did regarding the console log outputs I don't think we need to have nor bother QML with those errors - will those be taken in with this too or do they need another pull request?.

Flohack74 commented 5 years ago

No its good you can always add more stuff to an open PR, as you did already. I merge it and lets see what happens ;)