search

ubports / ubports-installer

A simple tool to install Ubuntu Touch on UBports devices
https://github.com/ubports/ubports-installer/releases
GNU General Public License v3.0
540 stars 119 forks source link

fastboot:reboot* should be similar to adb:reboot to_state #2837

Open JamiKettunen opened 2 years ago

JamiKettunen commented 2 years ago

Similar to

      - actions:
          - adb:reboot:
              to_state: "recovery"

the following should also work

      - actions:
          - fastboot:reboot:
              to_state: "recovery"

As it stands you have to use

      - actions:
          - fastboot:reboot_recovery:

and the same is also true for fastboot:reboot_fastboot and fastboot:reboot_bootloader.

Is there any reason adb:reboot and fastboot:reboot should work differently with regard to booting to different states?

amartinz commented 2 years ago

Not really, when implementing and adding more targets, i copy pasted what was already existing.

I agree, would be nicer to make them look the same.