search

ubports / ubuntu-touch

Ubuntu Touch's issue inbox is now migrated to GitLab.
https://gitlab.com/ubports/ubuntu-touch
1.29k stars 110 forks source link

Notification toasts appear when enableIndicatorsWhileLocked is disabled #1442

Open maximumhax opened 4 years ago

maximumhax commented 4 years ago

under settings / security+privacy if you uncheck notifications, lock screen will still show the notification when it first received. Then it goes away and stays hidden until you enter password. I believe if this is unchecked no nnotification should be displayed at all.

UniversalSuperBox commented 4 years ago

Hi @maximumhax, I hope you don't mind my editing of your title.

The setting "When locked, allow: Notifications and quick settings" in system-settings enables and disables the AccountsService's enableIndicatorsWhileLocked setting. The language of this option is confusing. Lomiri uses this setting only to disable the indicator bar, while its wording indicates that all notifications will be disabled on the lock screen. Notification toast messages still appear when the indicators are disabled.

This could potentially be fixed by changing the wording of the setting in system-settings so it does not imply that it disables notifications. Or, we could disable notification toasts when enableIndicatorsWhileLocked is false. Or, we could introduce a third option that hides notification content as well. Or some other option I haven't thought of.