Torch button not visible in mediatek devices

mihaelmilea commented 7 years ago

Mediatek devices do not have open source drivers for the flashlight, so it ( #79 ) does not appear on them. The only possible way to fix this would be using the camera API (or keep digging for the mediatek flashlight drivers).

Flohack74 commented 7 years ago

Hmm on hammerhead it is there... Someone with a turbo needs to confirm. But also @rubencarneiro mentioned it is not always visible. Maybe we got a problem with loading it correctly?

mihaelmilea commented 7 years ago

@Stefano0101 - can you confirm this please?

Stefano0101 commented 7 years ago

there is nfsprodriver-indicator-torch icon, but not the actual feature, just a blank black space nothing else Turbo, devel channel, version 19, 26/8/17

mihaelmilea commented 7 years ago

Yes, there is the indicator-torch in the open store and that installs the indicator in the upper menu that becomes visible after a restart and there I can find on and off menus but those don't do anything. Is this the new torch feature or is it something else somewhere in the battery menu?

Stefano0101 commented 7 years ago

Yeah, I know, tried that indicator, did not worked, uninstalled it and this one is there by default. I have not installed this one. Anyway, it doesn't work, as there is nothing to click/tap on.

I tried to uninnstall and reinstall the indicator and it doesn't work. The previously mentioned indicator has gone now.

28.08.2017, 12:50, "Mihael Milea" notifications@github.com:Yes, there is the indicator-torch in the open store and that installs the indicator in the upper menu that becomes visible after a restart and there I can find on and off menus but those don't do anything. Is this the new torch feature or is it something else somewhere in the battery menu?

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

mihaelmilea commented 7 years ago

There is nothing in my menu! Is there a way you can attach a screen shot?

Stefano0101 commented 7 years ago

It was the residual icon, now properly uninstalled(the indicator light) and there is nothing left.

NeoTheThird commented 7 years ago

The Pro 5 (and some other non qcom devices) does not have open source drivers for the flashlight, so it does not appear on them and only works on Nexus 5, Oneplus One and Fairphone 2, iirc. The only possible way to fix this would be using the camera API (or keep digging for the mediatek flashlight drivers).

NeoTheThird commented 7 years ago

@mihaelmilea I took the liberty to modify the description. Hope you don't mind.

mihaelmilea commented 7 years ago

Not at all, not at all! Thank you!

Stefano0101 commented 7 years ago

Pro 5 has a Samsung Exynos processor.

tomoqv commented 7 years ago

This thread is somewhat confusing. @NeoTheThird says that flashlight works on N5, OPO and FP2, but flashlight has never worked on my OPO running 15.04 devel.

Edit: I just discovered the Flashlight option under the Battery indicator and it works! However, uTorch and Indicator Torch from the OpenStore still don't work.

PhoenixLandPirate commented 7 years ago

I beleive this is fixed next ota.

I have some features from the next Ota such as backgrounds, the channel switcher etc.

One update I have gives me the option to use a torch on the opo under the battery indicator.

So my oneplus one's torch works.

I dont want to close this incase it doesnt work on every device but we can remove bacon.

tomoqv commented 7 years ago

@ChloeWolfieGirl Yes, I noticed the flashlight option under battery indicator, thanks.

NeoTheThird commented 7 years ago

@tomoqv

Edit: I just discovered the Flashlight option under the Battery indicator and it works! However, uTorch and Indicator Torch from the OpenStore still don't work.

My guess is that uTorch and Indicator Torch use the camera API to activate the led which does not work currently on the Oneplus One... :( We wanted to avoid using it, since it uses more battery, but @mariogrip what do you think, could we use it for mediatek devices?

@ChloeWolfieGirl thanks for the hint.

NeoTheThird commented 7 years ago

In case someone is interested in adding the camera api as a fallback in case no driver is available, the implementation of the flashlight switch is done in these commits:

As a reference, indicator-torch and uTorch are available.