ubports / ubuntu-touch

Ubuntu Touch's issue inbox is now migrated to GitLab.
https://gitlab.com/ubports/ubuntu-touch
1.28k stars 110 forks source link

Physical volume button with upside down phone should be swapped #465

Open mymike00 opened 6 years ago

mymike00 commented 6 years ago

Description of the feature

Physical volume button shod be swapped when using the phone in portrait mode but upside down

Steps to reproduce

Take your phone in portrait mode but upside down, without the rotation lock

Expected behavior

lockwhen I press the volume physical button at the top (usually at the bottom) the volume should increase and when I press the one at the bottom, the volume should decrease

Actual behavior

decreasethe button at the top decreases the volume and viceversa

mymike00 commented 6 years ago

@NeoTheThird why did you add needs confermation?

NeoTheThird commented 6 years ago

Because that's the policy. Until another user confirms it, that's the label we use.

mymike00 commented 6 years ago

ah ok. anyway, it's not difficult to reproduce and confirm

advocatux commented 6 years ago

This bug is only related to Rc, r25? Because it doesn't happen in stable channel (ota-3).

mymike00 commented 6 years ago

@advocatux you mean if you rotate the phone upside down and press the button that normally raise up the volume the volume will decrease?

advocatux commented 6 years ago

I'll try to be more clear. Let's call A to the spot you have to press on the button to raise the volume, and B to the spot to lower it.

It doesn't matter the screen position. Portrait or landscape, upside-down o no, when I press A the volume raises, and when I press B the volume goes down. So it's working as intended in Stable.

mymike00 commented 6 years ago

OK, I'll be more clear too. This issue is to change the behavior in upside-down mode: when you press A the volume should go down and B should raise, because A and B are swapped up-down

advocatux commented 6 years ago

I think I know from where you're coming. When the phone is upside-down in landscape, A is at the left and B is at the right but you see the volume progress bar (pop-up) going right when you press the left (A) to raise the volume, and the progress bar going to the left when you press the right (B) spot.

I think this is the desired behavior and shouldn't change. I like that A is always for raising the volume, and B for lowering it.

mymike00 commented 6 years ago

I want to change the button behavior when the phone is in portrait mode upside-down so that A is at the bottom and B at the top. In that mode, I have to press the button at the top, B, to decrease the volume and the button at the bottom, A, to raise it up...

Arc676 commented 6 years ago

I can confirm that this is also the behavior on the devel channel (r351, 16.04). However, as stated by others, this seems to be logical behavior. Maybe it can be a setting so users can choose? Something along the lines of "Swap volume keys when phone is upside down" and an analogous setting for when the phone is rotated counterclockwise relative to standard portrait, since the volume bar moves in the opposite direction of the volume key pressed i.e. if you press the volume up key, which is now on your left, the volume bar expands towards the right.

mymike00 commented 6 years ago

Oh, I didn't think about the landscape thing and the volume bar... that'd be useful too!

hummlbach commented 6 years ago

@neothethird i think this should be labeled as enhancement or opinion an the confirmation label can removed. Also I strongly assume this is not device specific (in the sense that the behavior isn't as suggested here on any device...)

mateosalta commented 6 years ago

I like the idea, I think I would use this on my phone - should be configurable in settings for sure, as some might not expect this at first.

For sure I would like this on the tablets, as landscape on devices like the nexus 7 is ambiguous, and I press the volume the wrong direction a lot - a left/vol up right/vol down would make sense

mymike00 commented 6 years ago

we were thinking the opposite :sweat_smile: as the volume bar goes to the right when you raise up the volume volume-bar a mockup to recap what we said:

Button A is always the one nearest to the camera in the image, and button B the other one

volume-button-rotated-phone

mateosalta commented 6 years ago

Oh, whops, thats what I ment to say, being the same as indicator direction 😄

dark-eye commented 6 years ago

I think this should be an option you can toggle on and off. As it doesn't make sense to me but since its an existing issue it probably make sense to some people, probably do to different (absolute vs relative ) space orientation or something...