search

ubports / ubuntu-ui-toolkit

Moved to https://gitlab.com/ubports/core/lomiri-ui-toolkit
https://gitlab.com/ubports/core/lomiri-ui-toolkit
GNU Lesser General Public License v3.0
13 stars 21 forks source link

when determining the height of the keyboard rectangle, take Screen.devicePixelRatio into account #25

Closed balcy closed 5 years ago

balcy commented 5 years ago

without that the popups are scrolled up too much, if the on screen keyboard is shown

see issue https://github.com/ubports/morph-browser/issues/52 of morph-browser

fixes https://github.com/ubports/morph-browser/issues/52

balcy commented 5 years ago

@mariogrip do you know why it could not be built ? The error messages in the Jenkins seem not connected to the code change...

UniversalSuperBox commented 5 years ago

It looks like the failure is due to failing tests, which previously were ignored due to tests not being enabled on CI. We should fix those tests...

UniversalSuperBox commented 5 years ago

Thanks to https://github.com/ubports/ubuntu-ui-toolkit/pull/30 and https://github.com/ubports/ubuntu-ui-toolkit/pull/31, we finally have everything in place to build the UITK again and PRs can be reviewed. I'll start reviewing this one now.